vpython: Forcefully clear PYTHON* environment.

vpython: Forcefully clear PYTHON* environment.

Forcefully remove PYTHONPATH and PYTHONHOME from the environment of the
executed Python processes.

This prevents a situation where "vpython" runs an isolated Python
intepreter, but that Python interpreter runs a subcommand sans isolation
flags that then uses the propagated PYTHON* environment.

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2867843002
Committed: https://github.com/luci/luci-go/commit/5a6585763abfb7a994ab2488a0155efe94bdc473

[dnj, 2017-05-08 18:56:34]

PTAL

[iannucci, 2017-05-08 18:59:08]

lgtm

https://codereview.chromium.org/2867843002/diff/1/vpython/run.go
File vpython/run.go (right):

https://codereview.chromium.org/2867843002/diff/1/vpython/run.go#newcode75
vpython/run.go:75: e.Remove("PYTHONHOME")
what about site path stuff? or do these cover that?

[dnj, 2017-05-08 19:03:07]

https://codereview.chromium.org/2867843002/diff/1/vpython/run.go
File vpython/run.go (right):

https://codereview.chromium.org/2867843002/diff/1/vpython/run.go#newcode75
vpython/run.go:75: e.Remove("PYTHONHOME")
On 2017/05/08 18:59:08, iannucci wrote:
> what about site path stuff? or do these cover that?

Adding PYTHONNOUSERSITE, which prevents this.

[dnj, 2017-05-08 19:13:37]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-05-08 19:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2867843002/#ps20001
(title: "block user site too")

[commit-bot: I haz the power, 2017-05-08 19:13:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:20:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494270817042920,
"parent_rev": "6ce16181341af32a25dc03c08eb71739fea74b18", "commit_rev":
"5a6585763abfb7a994ab2488a0155efe94bdc473"}

[commit-bot: I haz the power, 2017-05-08 19:20:55]

Description was changed from

==========
vpython: Forcefully clear PYTHON* environment.

Forcefully remove PYTHONPATH and PYTHONHOME from the environment of the
executed Python processes.

This prevents a situation where "vpython" runs an isolated Python
intepreter, but that Python interpreter runs a subcommand sans isolation
flags that then uses the propagated PYTHON* environment.

BUG=None
TEST=None
R=iannucci@chromium.org
==========

to

==========
vpython: Forcefully clear PYTHON* environment.

Forcefully remove PYTHONPATH and PYTHONHOME from the environment of the
executed Python processes.

This prevents a situation where "vpython" runs an isolated Python
intepreter, but that Python interpreter runs a subcommand sans isolation
flags that then uses the propagated PYTHON* environment.

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2867843002
Committed:
https://github.com/luci/luci-go/commit/5a6585763abfb7a994ab2488a0155efe94bdc473
==========

[commit-bot: I haz the power, 2017-05-08 19:20:56]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/5a6585763abfb7a994ab2488a0155efe94bdc473