vpython: Leave "pip" and related tools.

vpython: Leave "pip" and related tools.

vpython currently uninstalls "pip" abnd "wheel" on setup completion to
prevent giving the impression that package installation is possible in
the hermetic VirtualEnv. However, neither of these tools is actually
damaging, and some things may want to import and/or use "pip" and
"wheel" in acceptable contexts (packages, or test directory, etc.)

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2864423002
Committed: https://github.com/luci/luci-go/commit/6ce16181341af32a25dc03c08eb71739fea74b18

[dnj, 2017-05-08 17:51:58]

The CQ bit was checked by dnj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 17:52:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:59:56]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-05-08 18:02:41]

The CQ bit was checked by dnj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 18:02:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:09:37]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-08 18:15:09]

Won't this break hermeticity of the virtualenvs? Folks could
install/upgrade/uninstall other wheels inside a venv, right?

[dnj, 2017-05-08 18:27:17]

On 2017/05/08 18:15:09, iannucci wrote:
> Won't this break hermeticity of the virtualenvs? Folks could
> install/upgrade/uninstall other wheels inside a venv, right?

Shouldn't be able to b/c it's still read-only. The existence of the tool and its
associated libraries don't change that.

[iannucci, 2017-05-08 18:58:29]

ok, lgtm

https://codereview.chromium.org/2864423002/diff/20001/vpython/venv/venv.go
File vpython/venv/venv.go (right):

https://codereview.chromium.org/2864423002/diff/20001/vpython/venv/venv.go#ne...
vpython/venv/venv.go:33: // time the layout of a VirtualEnv environment change.
changes

[dnj, 2017-05-08 19:01:24]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-05-08 19:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2864423002/#ps40001
(title: "fix word")

[commit-bot: I haz the power, 2017-05-08 19:01:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:11:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494270084267310,
"parent_rev": "a38c829d72db13ca50967a66548968222f89a9e8", "commit_rev":
"6ce16181341af32a25dc03c08eb71739fea74b18"}

[commit-bot: I haz the power, 2017-05-08 19:11:56]

Description was changed from

==========
vpython: Leave "pip" and related tools.

vpython currently uninstalls "pip" abnd "wheel" on setup completion to
prevent giving the impression that package installation is possible in
the hermetic VirtualEnv. However, neither of these tools is actually
damaging, and some things may want to import and/or use "pip" and
"wheel" in acceptable contexts (packages, or test directory, etc.)

BUG=None
TEST=None
R=iannucci@chromium.org
==========

to

==========
vpython: Leave "pip" and related tools.

vpython currently uninstalls "pip" abnd "wheel" on setup completion to
prevent giving the impression that package installation is possible in
the hermetic VirtualEnv. However, neither of these tools is actually
damaging, and some things may want to import and/or use "pip" and
"wheel" in acceptable contexts (packages, or test directory, etc.)

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2864423002
Committed:
https://github.com/luci/luci-go/commit/6ce16181341af32a25dc03c08eb71739fea74b18
==========

[commit-bot: I haz the power, 2017-05-08 19:11:57]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/6ce16181341af32a25dc03c08eb71739fea74b18