Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2867683003:
[i18n] dir header i18n-content/values to $i18n (Closed)
Description[i18n] dir header i18n-content/values to $i18n
This CL changes the directory listing header from using the older
i18n-content and i18n-values to the faster $i18n localization code. The
resulting UI looks the same.
BUG=677338
Review-Url: https://codereview.chromium.org/2867683003
Cr-Commit-Position: refs/heads/master@{#470759}
Committed: https://chromium.googlesource.com/chromium/src/+/c714b929856634f69e66588db294ccb8b785ad25
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix innerHTML #Messages
Total messages: 26 (16 generated)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
On 2017/05/09 00:00:50, dschuyler wrote: > The CQ bit was checked by mailto:dschuyler@chromium.org to run a CQ dry run Before and after shots (which should look the same) at http://imgur.com/a/2i5Il
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
LGTM except one complaint https://codereview.chromium.org/2867683003/diff/1/net/base/dir_header.html File net/base/dir_header.html (right): https://codereview.chromium.org/2867683003/diff/1/net/base/dir_header.html#ne... net/base/dir_header.html:195: <div id="listingParsingErrorBox" .innerHTML="$i18n{listingParsingErrorBoxText}"> nit: is that legit? Shouldn't it just be a i18nRaw{foo} as a child?
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2867683003/diff/1/net/base/dir_header.html File net/base/dir_header.html (right): https://codereview.chromium.org/2867683003/diff/1/net/base/dir_header.html#ne... net/base/dir_header.html:195: <div id="listingParsingErrorBox" .innerHTML="$i18n{listingParsingErrorBoxText}"> On 2017/05/09 18:14:54, tommycli wrote: > nit: is that legit? Shouldn't it just be a i18nRaw{foo} as a child? Thanks! This text includes a url so it needs i18nRaw. There are some replacements in that string too, so I looked into those. One is the product name and the other is the location, which is uri escaped here https://cs.chromium.org/chromium/src/net/base/dir_header.html?type=cs&q=listi... Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2867683003/#ps20001 (title: "fix innerHTML")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + davidben@chromium.org
davidben@ for OWNER approval.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494460382528490,
"parent_rev": "39a2ba43e67ba75529e838adc853f2ad1f2ce473", "commit_rev":
"c714b929856634f69e66588db294ccb8b785ad25"}
Message was sent while issue was closed.
Description was changed from ========== [i18n] dir header i18n-content/values to $i18n This CL changes the directory listing header from using the older i18n-content and i18n-values to the faster $i18n localization code. The resulting UI looks the same. BUG=677338 ========== to ========== [i18n] dir header i18n-content/values to $i18n This CL changes the directory listing header from using the older i18n-content and i18n-values to the faster $i18n localization code. The resulting UI looks the same. BUG=677338 Review-Url: https://codereview.chromium.org/2867683003 Cr-Commit-Position: refs/heads/master@{#470759} Committed: https://chromium.googlesource.com/chromium/src/+/c714b929856634f69e66588db294... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c714b929856634f69e66588db294... |
