Chromium Code Reviews Chromium Code Reviews
Issue 2867683003:
[i18n] dir header i18n-content/values to $i18n (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html i18n-values="dir:textdirection;lang:language"> | 3 <html dir="$i18n{textdirection}" lang="$i18n{language}"> |
| 4 | 4 |
| 5 <head> | 5 <head> |
| 6 <meta charset="utf-8"> | 6 <meta charset="utf-8"> |
| 7 <meta name="google" value="notranslate"> | 7 <meta name="google" value="notranslate"> |
| 8 | 8 |
| 9 <script> | 9 <script> |
| 10 function addRow(name, url, isdir, | 10 function addRow(name, url, isdir, |
| 11 size, size_string, date_modified, date_modified_string) { | 11 size, size_string, date_modified, date_modified_string) { |
| 12 if (name == "." || name == "..") | 12 if (name == "." || name == "..") |
| 13 return; | 13 return; |
| (...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 185 display: none; | 185 display: none; |
| 186 } | 186 } |
| 187 </style> | 187 </style> |
| 188 | 188 |
| 189 <title id="title"></title> | 189 <title id="title"></title> |
| 190 | 190 |
| 191 </head> | 191 </head> |
| 192 | 192 |
| 193 <body> | 193 <body> |
| 194 | 194 |
| 195 <div id="listingParsingErrorBox" i18n-values=".innerHTML:listingParsingErrorBoxT ext"></div> | 195 <div id="listingParsingErrorBox" .innerHTML="$i18n{listingParsingErrorBoxText}"> |
|
tommycli
2017/05/09 18:14:54
nit: is that legit? Shouldn't it just be a i18nRaw
dschuyler
2017/05/09 19:07:16
Thanks!
This text includes a url so it needs i18nR
| |
| 196 </div> | |
| 196 | 197 |
| 197 <h1 id="header" i18n-content="header"></h1> | 198 <h1 id="header">$i18n{header}</h1> |
| 198 | 199 |
| 199 <div id="parentDirLinkBox" style="display:none"> | 200 <div id="parentDirLinkBox" style="display:none"> |
| 200 <a id="parentDirLink" class="icon up"> | 201 <a id="parentDirLink" class="icon up"> |
| 201 <span id="parentDirText" i18n-content="parentDirText"></span> | 202 <span id="parentDirText">$i18n{parentDirText}</span> |
| 202 </a> | 203 </a> |
| 203 </div> | 204 </div> |
| 204 | 205 |
| 205 <table> | 206 <table> |
| 206 <thead> | 207 <thead> |
| 207 <tr class="header" id="theader"> | 208 <tr class="header" id="theader"> |
| 208 <th i18n-content="headerName" onclick="javascript:sortTable(0);"></th> | 209 <th onclick="javascript:sortTable(0);">$i18n{headerName}</th> |
| 209 <th class="detailsColumn" i18n-content="headerSize" onclick="javascript:so rtTable(1);"></th> | 210 <th class="detailsColumn" onclick="javascript:sortTable(1);"> |
| 210 <th class="detailsColumn" i18n-content="headerDateModified" onclick="javas cript:sortTable(2);"></th> | 211 $i18n{headerSize} |
| 212 </th> | |
| 213 <th class="detailsColumn" onclick="javascript:sortTable(2);"> | |
| 214 $i18n{headerDateModified} | |
| 215 </th> | |
| 211 </tr> | 216 </tr> |
| 212 </thead> | 217 </thead> |
| 213 <tbody id="tbody"> | 218 <tbody id="tbody"> |
| 214 </tbody> | 219 </tbody> |
| 215 </table> | 220 </table> |
| 216 | 221 |
| 217 </body> | 222 </body> |
| 218 | 223 |
| 219 </html> | 224 </html> |
| OLD | NEW |
