Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2867673003: Have content::ResourceFetcher use FetchContext::CreateURLLoader (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Have content::ResourceFetcher use FetchContext::CreateURLLoader ...instead of Platform::CreateURLLoader. BUG=712913 Review-Url: https://codereview.chromium.org/2867673003 Cr-Commit-Position: refs/heads/master@{#470831} Committed: https://chromium.googlesource.com/chromium/src/+/4addda75cfc290605d77e545181bfbec17cdb163

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 33 (22 generated)
yhirano
3 years, 7 months ago (2017-05-10 12:00:59 UTC) #13
yhirano
+kinuko@
3 years, 7 months ago (2017-05-10 12:01:16 UTC) #15
kinuko
Is the error unrelated?
3 years, 7 months ago (2017-05-10 13:11:54 UTC) #18
kinuko
On 2017/05/10 13:11:54, kinuko wrote: > Is the error unrelated? (lgtm)
3 years, 7 months ago (2017-05-10 13:12:28 UTC) #19
yhirano
On 2017/05/10 13:12:28, kinuko wrote: > On 2017/05/10 13:11:54, kinuko wrote: > > Is the ...
3 years, 7 months ago (2017-05-10 13:48:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867673003/60001
3 years, 7 months ago (2017-05-10 13:49:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450037)
3 years, 7 months ago (2017-05-10 16:00:56 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867673003/60001
3 years, 7 months ago (2017-05-11 00:20:55 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451066)
3 years, 7 months ago (2017-05-11 03:29:00 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867673003/60001
3 years, 7 months ago (2017-05-11 04:42:17 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:52:50 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4addda75cfc290605d77e545181b...

Powered by Google App Engine
This is Rietveld 408576698