Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2867673002: Split QuicChromiumClientStreamDelegate::OnHeadersAvailable into (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split QuicChromiumClientStreamDelegate::OnHeadersAvailable into OnInitialHeadersAvailable and OnTrailingHeadersAvailable intead of forcing each subclass to track this themselves. BUG=716563 Review-Url: https://codereview.chromium.org/2867673002 Cr-Commit-Position: refs/heads/master@{#470307} Committed: https://chromium.googlesource.com/chromium/src/+/ec5b74ac86c81819fb765266c80dcb96590b0674

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -77 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 2 chunks +15 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 4 chunks +48 lines, -23 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 11 chunks +22 lines, -14 lines 0 comments Download
M net/quic/chromium/quic_http_stream.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (16 generated)
Ryan Hamilton
3 years, 7 months ago (2017-05-08 04:20:50 UTC) #2
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-05-08 18:08:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867673002/40001
3 years, 7 months ago (2017-05-09 13:27:31 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 13:31:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec5b74ac86c81819fb765266c80d...

Powered by Google App Engine
This is Rietveld 408576698