Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.cc

Issue 2867673002: Split QuicChromiumClientStreamDelegate::OnHeadersAvailable into (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.h ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/bidirectional_stream_quic_impl.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.cc b/net/quic/chromium/bidirectional_stream_quic_impl.cc
index ca231baf4fd47feade49b651069f483ca411f065..041cb34b2512bb892604503bfab28180a6a60d41 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.cc
@@ -35,7 +35,6 @@ BidirectionalStreamQuicImpl::BidirectionalStreamQuicImpl(
closed_stream_sent_bytes_(0),
closed_is_first_stream_(false),
has_sent_headers_(false),
- has_received_headers_(false),
send_request_headers_automatically_(true),
weak_factory_(this) {}
@@ -228,21 +227,23 @@ bool BidirectionalStreamQuicImpl::GetLoadTimingInfo(
return true;
}
-void BidirectionalStreamQuicImpl::OnHeadersAvailable(
+void BidirectionalStreamQuicImpl::OnInitialHeadersAvailable(
const SpdyHeaderBlock& headers,
size_t frame_len) {
headers_bytes_received_ += frame_len;
negotiated_protocol_ = kProtoQUIC;
- if (!has_received_headers_) {
- has_received_headers_ = true;
- connect_timing_ = session_->GetConnectTiming();
- if (delegate_)
- delegate_->OnHeadersReceived(headers);
- } else {
- if (delegate_)
- delegate_->OnTrailersReceived(headers);
- // |this| can be destroyed after this point.
- }
+ connect_timing_ = session_->GetConnectTiming();
+ if (delegate_)
+ delegate_->OnHeadersReceived(headers);
+}
+
+void BidirectionalStreamQuicImpl::OnTrailingHeadersAvailable(
+ const SpdyHeaderBlock& headers,
+ size_t frame_len) {
+ headers_bytes_received_ += frame_len;
+ if (delegate_)
+ delegate_->OnTrailersReceived(headers);
+ // |this| can be destroyed after this point.
}
void BidirectionalStreamQuicImpl::OnDataAvailable() {
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.h ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698