Remove {LocallyStored,SiteBound}CredentialData

Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615
Review-Url: https://codereview.chromium.org/2867643004
Cr-Commit-Position: refs/heads/master@{#470389}
Committed: https://chromium.googlesource.com/chromium/src/+/3965ba442d09131dd9e2e4fd576cddab672c4f29

[jdoerrie, 2017-05-08 15:10:00]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 15:10:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-05-08 16:33:10]

jdoerrie@chromium.org changed reviewers:
+ mkwst@chromium.org, thakis@chromium.org

[jdoerrie, 2017-05-08 16:33:10]

mkwst@chromium.org: Please review the whole CL.

thakis@chromium.org: Please rubber-stamp 
- tools/blink_rename_merge_helper/data/idl_blocklist.txt
-
third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html

[commit-bot: I haz the power, 2017-05-08 17:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:13:26]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-08 18:56:47]

On 2017/05/08 16:33:10, jdoerrie (slow this week) wrote:
> mailto:mkwst@chromium.org: Please review the whole CL.
> 
> mailto:thakis@chromium.org: Please rubber-stamp 
> - tools/blink_rename_merge_helper/data/idl_blocklist.txt

lgtm, but I think you can also just not change that file. Blocking a class that
doesn't exist doesn't hurt, and eventually we're going to delete that whole
directory.

> -
third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html

I don't know anything about the external/wpt tests.

[jdoerrie, 2017-05-08 22:45:48]

Description was changed from

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

BUG=714615
==========

to

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

BUG=714615
==========

[jdoerrie, 2017-05-08 22:45:48]

jdoerrie@chromium.org changed reviewers:
+ jochen@chromium.org

[jdoerrie, 2017-05-08 22:47:01]

On 2017/05/08 18:56:47, Nico wrote:
> On 2017/05/08 16:33:10, jdoerrie (slow this week) wrote:
> > mailto:mkwst@chromium.org: Please review the whole CL.
> > 
> > mailto:thakis@chromium.org: Please rubber-stamp 
> > - tools/blink_rename_merge_helper/data/idl_blocklist.txt
> 
> lgtm, but I think you can also just not change that file. Blocking a class
that
> doesn't exist doesn't hurt, and eventually we're going to delete that whole
> directory.

Thank you! I'll see what Mike has to say about this.

> 
> > -
>
third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
> 
> I don't know anything about the external/wpt tests.

Sorry, my bad. Adding jochen@ for
third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html

[Mike West, 2017-05-09 09:25:08]

LGTM.

Thanks for taking care of this! Would you mind adding a link to the SiteBound*
intent to ship thread to the CL description?

[jdoerrie, 2017-05-09 15:13:13]

Description was changed from

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

BUG=714615
==========

to

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615
==========

[jdoerrie, 2017-05-09 15:13:27]

Description was changed from

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615
==========

to

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615
==========

[jdoerrie, 2017-05-09 15:14:48]

Thanks, Mike!

Ping to jochen@ to please rubber-stamp 
third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html

[jochen (gone - plz use gerrit), 2017-05-09 16:24:31]

lgtm

[jdoerrie, 2017-05-09 16:26:31]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-05-09 16:27:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:29:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494347191252260, "parent_rev":
"d063660bf41b8868f1fa6323f0dc59e45ba8b189", "commit_rev":
"3965ba442d09131dd9e2e4fd576cddab672c4f29"}

[commit-bot: I haz the power, 2017-05-09 18:30:01]

Description was changed from

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615
==========

to

==========
Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG=714615

Review-Url: https://codereview.chromium.org/2867643004
Cr-Commit-Position: refs/heads/master@{#470389}
Committed:
https://chromium.googlesource.com/chromium/src/+/3965ba442d09131dd9e2e4fd576c...
==========

[commit-bot: I haz the power, 2017-05-09 18:30:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3965ba442d09131dd9e2e4fd576c...