third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp - Issue 2867643004: Remove {LocallyStored,SiteBound}CredentialData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

Issue 2867643004: Remove {LocallyStored,SiteBound}CredentialData (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h ('k') | third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

index e72270fa273381ed08f91153c6153060c478fc6e..de43bcd7f72d71ac094f28d4afc01813a754d0c9 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp

@@ -5,7 +5,7 @@

#include "modules/credentialmanager/FederatedCredential.h"

#include "bindings/core/v8/ExceptionState.h"

-#include "modules/credentialmanager/FederatedCredentialData.h"

+#include "modules/credentialmanager/FederatedCredentialInit.h"

#include "platform/credentialmanager/PlatformFederatedCredential.h"

#include "platform/weborigin/SecurityOrigin.h"

#include "public/platform/WebFederatedCredential.h"

@@ -18,7 +18,7 @@ FederatedCredential* FederatedCredential::Create(

}

FederatedCredential* FederatedCredential::Create(

- const FederatedCredentialData& data,

+ const FederatedCredentialInit& data,

ExceptionState& exception_state) {

if (data.id().IsEmpty()) {

exception_state.ThrowTypeError("'id' must not be empty.");