Chromium Code Reviews
DescriptionFixing a crash in our native messaging host binaries
This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent. The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.
The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.
BUG=718871
Review-Url: https://codereview.chromium.org/2857983008
Cr-Commit-Position: refs/heads/master@{#469646}
(cherry picked from commit e0ca3279b3b7ba5053a56f03fd57f7feb03d93ba)
Review-Url: https://codereview.chromium.org/2867623002 .
Cr-Commit-Position: refs/branch-heads/3071@{#434}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/13d77cbc3998a37f2a8e895831af67e7c0bf3752
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||