Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Issue 2867623002: Fixing a crash in our native messaging host binaries (Closed)

Created:
3 years, 7 months ago by joedow
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fixing a crash in our native messaging host binaries This CL fixes a crash which can occur if the native messaging pipeline is torn down immediately after a message is sent. The LogMessageHandler class will run a messaging delegate and then attempt to update a member variable. If the instance is destroyed, then an AV will occur. The fix is to check if the instance is still alive using a WeakPtr skip the member variable assignment if it has been torn down. BUG=718871 Review-Url: https://codereview.chromium.org/2857983008 Cr-Commit-Position: refs/heads/master@{#469646} (cherry picked from commit e0ca3279b3b7ba5053a56f03fd57f7feb03d93ba) Review-Url: https://codereview.chromium.org/2867623002 . Cr-Commit-Position: refs/branch-heads/3071@{#434} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/13d77cbc3998a37f2a8e895831af67e7c0bf3752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M remoting/host/native_messaging/log_message_handler.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
joedow
3 years, 7 months ago (2017-05-06 23:12:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13d77cbc3998a37f2a8e895831af67e7c0bf3752.

Powered by Google App Engine
This is Rietveld 408576698