Fixing a crash in our native messaging host binaries

Fixing a crash in our native messaging host binaries

This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent.  The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.

The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.

BUG=718871
Review-Url: https://codereview.chromium.org/2857983008
Cr-Commit-Position: refs/heads/master@{#469646}
Committed: https://chromium.googlesource.com/chromium/src/+/e0ca3279b3b7ba5053a56f03fd57f7feb03d93ba

[joedow, 2017-05-04 23:46:08]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[joedow, 2017-05-04 23:46:47]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[joedow, 2017-05-04 23:46:48]

PTAL!

[commit-bot: I haz the power, 2017-05-04 23:47:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:05:26]

Dry run: This issue passed the CQ dry run.

[Jamie, 2017-05-05 00:38:11]

lgtm

[joedow, 2017-05-05 14:32:07]

Description was changed from

==========
Fixing a crash in our native messaging host binaries

This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent.  The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.

The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.

BUG=
==========

to

==========
Fixing a crash in our native messaging host binaries

This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent.  The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.

The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.

BUG=718871
==========

[joedow, 2017-05-05 14:32:25]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:32:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 14:37:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493994745700790, "parent_rev":
"3c633b6376623a8d0de8d567a822c6b96d2c8263", "commit_rev":
"e0ca3279b3b7ba5053a56f03fd57f7feb03d93ba"}

[commit-bot: I haz the power, 2017-05-05 14:37:25]

Description was changed from

==========
Fixing a crash in our native messaging host binaries

This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent.  The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.

The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.

BUG=718871
==========

to

==========
Fixing a crash in our native messaging host binaries

This CL fixes a crash which can occur if the native messaging pipeline is
torn down immediately after a message is sent.  The LogMessageHandler class
will run a messaging delegate and then attempt to update a member variable.
If the instance is destroyed, then an AV will occur.

The fix is to check if the instance is still alive using a WeakPtr skip the
member variable assignment if it has been torn down.

BUG=718871

Review-Url: https://codereview.chromium.org/2857983008
Cr-Commit-Position: refs/heads/master@{#469646}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0ca3279b3b7ba5053a56f03fd57...
==========

[commit-bot: I haz the power, 2017-05-05 14:37:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0ca3279b3b7ba5053a56f03fd57...