Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2867413002: [ash-md] Updated the overflow shelf to change colors based on the wallpaper. (Closed)

Created:
3 years, 7 months ago by bruthig
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Updated the overflow shelf to change colors based on the wallpaper. The overflow shelf was incorrectly hard coded to use a black background. This change updates the overflow shelf color based on the wallpaper color. BUG=719724 TEST=ash_unittest --gtest_filter=ShelfViewTest.OverflowShelfColorIsDerivedFromWallpaper Review-Url: https://codereview.chromium.org/2867413002 Cr-Commit-Position: refs/heads/master@{#470703} Committed: https://chromium.googlesource.com/chromium/src/+/5fa8d94b746048527041ad5d0e8a4c11f90cb597

Patch Set 1 #

Patch Set 2 : Added ShelfViewTest.OverflowShelfColorIsDerivedFromWallpaper test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -10 lines) Patch
M ash/shelf/overflow_bubble_view.h View 3 chunks +9 lines, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 4 chunks +17 lines, -6 lines 0 comments Download
M ash/shelf/shelf_background_animator_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 chunks +15 lines, -0 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ash/test/wallpaper_controller_test_api.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A ash/test/wallpaper_controller_test_api.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
bruthig
James, can you PTAL?
3 years, 7 months ago (2017-05-09 17:44:52 UTC) #6
James Cook
Can you add a test that it gets a non-default color?
3 years, 7 months ago (2017-05-09 17:51:39 UTC) #7
bruthig
James, can you take another look? I don't think the trybot failures are related.
3 years, 7 months ago (2017-05-10 17:32:57 UTC) #13
James Cook
LGTM
3 years, 7 months ago (2017-05-10 19:24:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867413002/20001
3 years, 7 months ago (2017-05-10 19:28:44 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:59:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5fa8d94b746048527041ad5d0e8a...

Powered by Google App Engine
This is Rietveld 408576698