Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2867403002: Revert of [turbofan] Add alignment parameter to StackSlot operator (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
v8-mips-ports_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add alignment parameter to StackSlot operator (patchset #7 id:120001 of https://codereview.chromium.org/2816743003/ ) Reason for revert: Seems to break cfi: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/9989 Original issue's description: > [turbofan] Add alignment parameter to StackSlot operator > > If alignment parameter is set, the memory returned by the > StackSlot operator will be aligned according to the parameter. > > The implementation goes like this. If alignment parameter is set > we allocate a bit more memory than actually needed and so we > can move the beginning of the StackSlot in order to have it aligned. > > > BUG= > > Review-Url: https://codereview.chromium.org/2816743003 > Cr-Commit-Position: refs/heads/master@{#45197} > Committed: https://chromium.googlesource.com/v8/v8/+/d8bfdb7a998adadc56aa5705a5998e75ceae7675 TBR=ahaas@chromium.org,clemensh@chromium.org,titzer@chromium.org,bmeurer@chromium.org,ivica.bogosavljevic@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2867403002 Cr-Commit-Position: refs/heads/master@{#45203} Committed: https://chromium.googlesource.com/v8/v8/+/63c5dd5dd4dbc097f831a38861bc041873f2116f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -255 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +2 lines, -11 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +3 lines, -25 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +28 lines, -51 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -29 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +2 lines, -29 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [turbofan] Add alignment parameter to StackSlot operator
3 years, 7 months ago (2017-05-09 16:13:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867403002/1
3 years, 7 months ago (2017-05-09 16:13:42 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 16:14:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/63c5dd5dd4dbc097f831a38861bc041873f...

Powered by Google App Engine
This is Rietveld 408576698