Recode shared memory usage on Windows, macOS and NaCl

Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

BUG=604726
Review-Url: https://codereview.chromium.org/2867193004
Cr-Commit-Position: refs/heads/master@{#474930}
Committed: https://chromium.googlesource.com/chromium/src/+/e80c576c7bdcd567ba96a4e1ceb9f845dcf1168e

[hajimehoshi, 2017-05-09 10:31:00]

Description was changed from

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

(This includes crrev/2873433004 and is blocked by that)

BUG=604726
==========

to

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

(This is blocked by https://codereview.chromium.org/2873433004/)

BUG=604726
==========

[hajimehoshi, 2017-05-25 06:21:21]

Description was changed from

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

(This is blocked by https://codereview.chromium.org/2873433004/)

BUG=604726
==========

to

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

BUG=604726
==========

[hajimehoshi, 2017-05-25 06:21:47]

hajimehoshi@chromium.org changed reviewers:
+ danakj@chromium.org

[hajimehoshi, 2017-05-25 06:21:58]

PTAL

[hajimehoshi, 2017-05-25 06:22:04]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 06:22:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 07:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 07:58:24]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-05-25 15:28:26]

LGTM

[Primiano Tucci (use gerrit), 2017-05-25 18:06:22]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-05-25 18:06:23]

I'd probably move the Decrement calls before the various munmap (or
declination). That will avoid passing an argument to an object that is half torn
down. This will avoid bugs in the future of the form "the Decrement call tried
to read back the mapped adddress but failed because the object is in an
inconsistent state".

looks good to me % that  but I am not an owner so defer to danakj@

[danakj, 2017-05-25 18:27:45]

That sounds good to me too.

On Thu, May 25, 2017 at 2:06 PM, <primiano@chromium.org> wrote:

> I'd probably move the Decrement calls before the various munmap (or
> declination). That will avoid passing an argument to an object that is
> half torn
> down. This will avoid bugs in the future of the form "the Decrement call
> tried
> to read back the mapped adddress but failed because the object is in an
> inconsistent state".
>
> looks good to me % that but I am not an owner so defer to danakj@
>
> https://codereview.chromium.org/2867193004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hajimehoshi, 2017-05-26 04:02:52]

Thank you! Done.

On 2017/05/25 18:27:45, danakj wrote:
> That sounds good to me too.
> 
> On Thu, May 25, 2017 at 2:06 PM, <mailto:primiano@chromium.org> wrote:
> 
> > I'd probably move the Decrement calls before the various munmap (or
> > declination). That will avoid passing an argument to an object that is
> > half torn
> > down. This will avoid bugs in the future of the form "the Decrement call
> > tried
> > to read back the mapped adddress but failed because the object is in an
> > inconsistent state".
> >
> > looks good to me % that but I am not an owner so defer to danakj@
> >
> > https://codereview.chromium.org/2867193004/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[hajimehoshi, 2017-05-26 04:02:57]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2017-05-26 04:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2867193004/#ps60001
(title: "Move decrementing before unmapping")

[commit-bot: I haz the power, 2017-05-26 04:04:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:49:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495771377543950,
"parent_rev": "bd33d604d7e749f71571fd34fd59a41b10e13bce", "commit_rev":
"e80c576c7bdcd567ba96a4e1ceb9f845dcf1168e"}

[commit-bot: I haz the power, 2017-05-26 05:49:55]

Description was changed from

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

BUG=604726
==========

to

==========
Recode shared memory usage on Windows, macOS and NaCl

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

BUG=604726

Review-Url: https://codereview.chromium.org/2867193004
Cr-Commit-Position: refs/heads/master@{#474930}
Committed:
https://chromium.googlesource.com/chromium/src/+/e80c576c7bdcd567ba96a4e1ceb9...
==========

[commit-bot: I haz the power, 2017-05-26 05:49:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e80c576c7bdcd567ba96a4e1ceb9...