base/memory/shared_memory_posix.cc - Issue 2867193004: Recode shared memory usage on Windows, macOS and NaCl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_posix.cc

Issue 2867193004: Recode shared memory usage on Windows, macOS and NaCl (Closed)

Patch Set: Move decrementing before unmapping Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/shared_memory_posix.cc

diff --git a/base/memory/shared_memory_posix.cc b/base/memory/shared_memory_posix.cc

index e3f333d657eb76e70d224251420e0931139747fe..b123849f27e75e9a338839294747b48e43e09a62 100644

--- a/base/memory/shared_memory_posix.cc

+++ b/base/memory/shared_memory_posix.cc

@@ -298,8 +298,8 @@ bool SharedMemory::Unmap() {

if (memory_ == NULL)

return false;

- munmap(memory_, mapped_size_);

SharedMemoryTracker::GetInstance()->DecrementMemoryUsage(*this);

+ munmap(memory_, mapped_size_);

memory_ = NULL;

mapped_size_ = 0;

return true;

« no previous file with comments | « base/memory/shared_memory_nacl.cc ('k') | base/memory/shared_memory_win.cc » ('j') | no next file with comments »