Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2866983002: mac: Don't set background color from a frame until frame is displayed (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Don't set background color from a frame until frame is displayed The first frame for dark-themed new tab pages still has a background color of white, even though the frame's content is all black tiles. Before this patch, we would set the background color to white, and then later put up the black tiles in front, resulting in a white flash. This updates all of those parts atomically in the same CATransaction. BUG=470669 Review-Url: https://codereview.chromium.org/2866983002 Cr-Commit-Position: refs/heads/master@{#469919} Committed: https://chromium.googlesource.com/chromium/src/+/cd8d494cec6d51ecddcb7e3ac09eb8661212e4f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
ccameron
Sorry, last one of these, promise!
3 years, 7 months ago (2017-05-07 21:24:40 UTC) #2
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-08 01:30:17 UTC) #3
ccameron
Thanks!
3 years, 7 months ago (2017-05-08 07:22:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866983002/1
3 years, 7 months ago (2017-05-08 07:22:47 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 07:55:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd8d494cec6d51ecddcb7e3ac09e...

Powered by Google App Engine
This is Rietveld 408576698