mac: Set background color from theme before NSView is added to window

mac: Set background color from theme before NSView is added to window

Update the color based on the window theme before the view is added to
the window, not after.

Fix the color for incognito windows (added a TODO and filed a bug
because some refactoring will be needed there).

BUG=470669
Review-Url: https://codereview.chromium.org/2866963002
Cr-Commit-Position: refs/heads/master@{#469903}
Committed: https://chromium.googlesource.com/chromium/src/+/3209ebcc6b2239b1f9cb806665d60a1096fcf53b

[ccameron, 2017-05-07 17:44:22]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 17:44:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-05-07 17:45:03]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2017-05-07 17:45:04]

ptal -- should have been obvious, but there were lots of other white flash
sources that are only now gone.

[Avi (use Gerrit), 2017-05-07 17:48:37]

lgtm

[commit-bot: I haz the power, 2017-05-07 18:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 18:05:11]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-05-07 18:26:37]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-07 18:26:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-07 18:31:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494181597749870, "parent_rev":
"b5f86b477cbd1d9ea3f8297a3501a4c788be9d5a", "commit_rev":
"3209ebcc6b2239b1f9cb806665d60a1096fcf53b"}

[commit-bot: I haz the power, 2017-05-07 18:32:00]

Description was changed from

==========
mac: Set background color from theme before NSView is added to window

Update the color based on the window theme before the view is added to
the window, not after.

Fix the color for incognito windows (added a TODO and filed a bug
because some refactoring will be needed there).

BUG=470669
==========

to

==========
mac: Set background color from theme before NSView is added to window

Update the color based on the window theme before the view is added to
the window, not after.

Fix the color for incognito windows (added a TODO and filed a bug
because some refactoring will be needed there).

BUG=470669

Review-Url: https://codereview.chromium.org/2866963002
Cr-Commit-Position: refs/heads/master@{#469903}
Committed:
https://chromium.googlesource.com/chromium/src/+/3209ebcc6b2239b1f9cb806665d6...
==========

[commit-bot: I haz the power, 2017-05-07 18:32:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3209ebcc6b2239b1f9cb806665d6...