Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2866863003: [Android, Tools] Speed up gn_to_cmake.py with caching (Closed)

Created:
3 years, 7 months ago by whywhat
Modified:
3 years, 7 months ago
Reviewers:
Peter Wen
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, nyquist+watch_chromium.org, wnwen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android, Tools] Speed up gn_to_cmake.py with caching BUG=694699 TEST=local run Review-Url: https://codereview.chromium.org/2866863003 Cr-Commit-Position: refs/heads/master@{#470299} Committed: https://chromium.googlesource.com/chromium/src/+/23bc56150efb4ae54f6662e8552ac693fb41d485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/android/gradle/gn_to_cmake.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
whywhat
PTaL
3 years, 7 months ago (2017-05-06 00:32:45 UTC) #2
Peter Wen
lgtm thanks!
3 years, 7 months ago (2017-05-08 13:13:19 UTC) #5
whywhat
On 2017/05/08 at 13:13:19, wnwen wrote: > lgtm thanks! Thanks. This doesn't seem to enable ...
3 years, 7 months ago (2017-05-08 17:39:24 UTC) #6
whywhat
On 2017/05/08 at 17:39:24, whywhat wrote: > On 2017/05/08 at 13:13:19, wnwen wrote: > > ...
3 years, 7 months ago (2017-05-08 17:41:36 UTC) #7
whywhat
On 2017/05/08 at 17:41:36, whywhat wrote: > On 2017/05/08 at 17:39:24, whywhat wrote: > > ...
3 years, 7 months ago (2017-05-08 18:40:34 UTC) #8
Peter Wen
Unfortunately I had many similar errors as well. Still quite a bit of work necessary ...
3 years, 7 months ago (2017-05-08 18:40:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866863003/1
3 years, 7 months ago (2017-05-08 18:41:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/288421)
3 years, 7 months ago (2017-05-08 23:29:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866863003/1
3 years, 7 months ago (2017-05-09 12:55:47 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 13:03:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23bc56150efb4ae54f6662e8552a...

Powered by Google App Engine
This is Rietveld 408576698