[Android, Tools] Speed up gn_to_cmake.py with caching

[Android, Tools] Speed up gn_to_cmake.py with caching

BUG=694699
TEST=local run

Review-Url: https://codereview.chromium.org/2866863003
Cr-Commit-Position: refs/heads/master@{#470299}
Committed: https://chromium.googlesource.com/chromium/src/+/23bc56150efb4ae54f6662e8552ac693fb41d485

[whywhat, 2017-05-06 00:32:44]

avayvod@chromium.org changed reviewers:
+ wxwen@chromium.org

[whywhat, 2017-05-06 00:32:45]

PTaL

[Peter Wen, 2017-05-08 13:12:43]

Description was changed from

==========
[Android, Tools] Speed up gn_to_cmake.py with caching

BUG=694699
TEST=local run
==========

to

==========
[Android, Tools] Speed up gn_to_cmake.py with caching

BUG=694699
TEST=local run
==========

[Peter Wen, 2017-05-08 13:12:43]

wnwen@chromium.org changed reviewers:
+ wnwen@chromium.org
- wxwen@chromium.org

[Peter Wen, 2017-05-08 13:13:19]

lgtm thanks!

[whywhat, 2017-05-08 17:39:24]

On 2017/05/08 at 13:13:19, wnwen wrote:
> lgtm thanks!

Thanks. This doesn't seem to enable me finding .cc/cpp files in Android Studio
though. Gradle Sync shows the following in the log:

2017-05-08 13:24:39,801 [  12248]   INFO - e.project.sync.GradleSyncState -
Started sync with Gradle for project 'clankium'. 
2017-05-08 13:24:39,992 [  12439]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
2017-05-08 13:24:39,994 [  12441]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
2017-05-08 13:24:40,863 [  13310]   INFO - xecution.GradleExecutionHelper -
Passing command-line args to Gradle Tooling API: [-Djava.awt.headless=true,
-Pandroid.injected.build.model.only=true,
-Pandroid.injected.build.model.only.advanced=true,
-Pandroid.injected.invoked.from.ide=true, --init-script,
/tmp/asLocalRepo.gradle, --init-script, /tmp/ijinit.gradle] 
2017-05-08 13:37:38,587 [ 791034]   INFO - ule.android.SdkModuleSetupStep - Set
Android SDK 'Android API 25 Platform'
(/usr/local/google/code/clankium/src/third_party/android_tools/sdk) to module
'_all' 
2017-05-08 13:37:38,840 [ 791287]   INFO - agnostic.FrequentEventDetector - Too
many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@3673cb6c
java.lang.Throwable
        at
com.intellij.openapi.diagnostic.FrequentEventDetector.eventHappened(FrequentEventDetector.java:74)
        at
com.intellij.openapi.application.impl.LaterInvocator.invokeLater(LaterInvocator.java:135)
        at
com.intellij.openapi.application.impl.ModalityInvokatorImpl.invokeLater(ModalityInvokatorImpl.java:46)
        at
com.intellij.openapi.application.impl.ApplicationImpl.invokeLater(ApplicationImpl.java:379)
        at
com.intellij.openapi.externalSystem.service.notification.ExternalSystemNotificationManager.lambda$showNotification$2(ExternalSystemNotificationManager.java:183)
        at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at
com.intellij.util.concurrency.BoundedTaskExecutor.runFirstTaskThenPollAndRunRest(BoundedTaskExecutor.java:178)
        at
com.intellij.util.concurrency.BoundedTaskExecutor.access$000(BoundedTaskExecutor.java:40)
        at
com.intellij.util.concurrency.BoundedTaskExecutor$2.run(BoundedTaskExecutor.java:197)
        at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
 
2017-05-08 13:37:38,844 [ 791291]   INFO - agnostic.FrequentEventDetector - Too
many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@14f685ab 
2017-05-08 13:37:39,040 [ 791487]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
2017-05-08 13:37:39,114 [ 791561]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
2017-05-08 13:37:39,141 [ 791588]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
2017-05-08 13:37:39,154 [ 791601]   INFO - e.project.sync.GradleSyncState - Sync
with Gradle successful for project 'clankium'. 

Note that it takes 13 minutes to sync.

[whywhat, 2017-05-08 17:41:36]

On 2017/05/08 at 17:39:24, whywhat wrote:
> On 2017/05/08 at 13:13:19, wnwen wrote:
> > lgtm thanks!
> 
> Thanks. This doesn't seem to enable me finding .cc/cpp files in Android Studio
though. Gradle Sync shows the following in the log:
> 
> 2017-05-08 13:24:39,801 [  12248]   INFO - e.project.sync.GradleSyncState -
Started sync with Gradle for project 'clankium'. 
> 2017-05-08 13:24:39,992 [  12439]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
> 2017-05-08 13:24:39,994 [  12441]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
> 2017-05-08 13:24:40,863 [  13310]   INFO - xecution.GradleExecutionHelper -
Passing command-line args to Gradle Tooling API: [-Djava.awt.headless=true,
-Pandroid.injected.build.model.only=true,
-Pandroid.injected.build.model.only.advanced=true,
-Pandroid.injected.invoked.from.ide=true, --init-script,
/tmp/asLocalRepo.gradle, --init-script, /tmp/ijinit.gradle] 
> 2017-05-08 13:37:38,587 [ 791034]   INFO - ule.android.SdkModuleSetupStep -
Set Android SDK 'Android API 25 Platform'
(/usr/local/google/code/clankium/src/third_party/android_tools/sdk) to module
'_all' 
> 2017-05-08 13:37:38,840 [ 791287]   INFO - agnostic.FrequentEventDetector -
Too many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@3673cb6c
> java.lang.Throwable
>         at
com.intellij.openapi.diagnostic.FrequentEventDetector.eventHappened(FrequentEventDetector.java:74)
>         at
com.intellij.openapi.application.impl.LaterInvocator.invokeLater(LaterInvocator.java:135)
>         at
com.intellij.openapi.application.impl.ModalityInvokatorImpl.invokeLater(ModalityInvokatorImpl.java:46)
>         at
com.intellij.openapi.application.impl.ApplicationImpl.invokeLater(ApplicationImpl.java:379)
>         at
com.intellij.openapi.externalSystem.service.notification.ExternalSystemNotificationManager.lambda$showNotification$2(ExternalSystemNotificationManager.java:183)
>         at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at
com.intellij.util.concurrency.BoundedTaskExecutor.runFirstTaskThenPollAndRunRest(BoundedTaskExecutor.java:178)
>         at
com.intellij.util.concurrency.BoundedTaskExecutor.access$000(BoundedTaskExecutor.java:40)
>         at
com.intellij.util.concurrency.BoundedTaskExecutor$2.run(BoundedTaskExecutor.java:197)
>         at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
>  
> 2017-05-08 13:37:38,844 [ 791291]   INFO - agnostic.FrequentEventDetector -
Too many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@14f685ab 
> 2017-05-08 13:37:39,040 [ 791487]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> 2017-05-08 13:37:39,114 [ 791561]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> 2017-05-08 13:37:39,141 [ 791588]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> 2017-05-08 13:37:39,154 [ 791601]   INFO - e.project.sync.GradleSyncState -
Sync with Gradle successful for project 'clankium'. 
> 
> Note that it takes 13 minutes to sync.

Later the sync is shown as failed with lots of messages like: "You have called
ADD_LIBRARY for library ipc_param_traits without any source files. This
typically indicates a problem with your CMakeLists.txt file"

[whywhat, 2017-05-08 18:40:34]

On 2017/05/08 at 17:41:36, whywhat wrote:
> On 2017/05/08 at 17:39:24, whywhat wrote:
> > On 2017/05/08 at 13:13:19, wnwen wrote:
> > > lgtm thanks!
> > 
> > Thanks. This doesn't seem to enable me finding .cc/cpp files in Android
Studio though. Gradle Sync shows the following in the log:
> > 
> > 2017-05-08 13:24:39,801 [  12248]   INFO - e.project.sync.GradleSyncState -
Started sync with Gradle for project 'clankium'. 
> > 2017-05-08 13:24:39,992 [  12439]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
> > 2017-05-08 13:24:39,994 [  12441]   INFO - s.plugins.gradle.GradleManager -
Instructing gradle to use java from /usr/local/buildtools/java/jdk 
> > 2017-05-08 13:24:40,863 [  13310]   INFO - xecution.GradleExecutionHelper -
Passing command-line args to Gradle Tooling API: [-Djava.awt.headless=true,
-Pandroid.injected.build.model.only=true,
-Pandroid.injected.build.model.only.advanced=true,
-Pandroid.injected.invoked.from.ide=true, --init-script,
/tmp/asLocalRepo.gradle, --init-script, /tmp/ijinit.gradle] 
> > 2017-05-08 13:37:38,587 [ 791034]   INFO - ule.android.SdkModuleSetupStep -
Set Android SDK 'Android API 25 Platform'
(/usr/local/google/code/clankium/src/third_party/android_tools/sdk) to module
'_all' 
> > 2017-05-08 13:37:38,840 [ 791287]   INFO - agnostic.FrequentEventDetector -
Too many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@3673cb6c
> > java.lang.Throwable
> >         at
com.intellij.openapi.diagnostic.FrequentEventDetector.eventHappened(FrequentEventDetector.java:74)
> >         at
com.intellij.openapi.application.impl.LaterInvocator.invokeLater(LaterInvocator.java:135)
> >         at
com.intellij.openapi.application.impl.ModalityInvokatorImpl.invokeLater(ModalityInvokatorImpl.java:46)
> >         at
com.intellij.openapi.application.impl.ApplicationImpl.invokeLater(ApplicationImpl.java:379)
> >         at
com.intellij.openapi.externalSystem.service.notification.ExternalSystemNotificationManager.lambda$showNotification$2(ExternalSystemNotificationManager.java:183)
> >         at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> >         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> >         at
com.intellij.util.concurrency.BoundedTaskExecutor.runFirstTaskThenPollAndRunRest(BoundedTaskExecutor.java:178)
> >         at
com.intellij.util.concurrency.BoundedTaskExecutor.access$000(BoundedTaskExecutor.java:40)
> >         at
com.intellij.util.concurrency.BoundedTaskExecutor$2.run(BoundedTaskExecutor.java:197)
> >         at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> >         at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> >         at java.lang.Thread.run(Thread.java:745)
> >  
> > 2017-05-08 13:37:38,844 [ 791291]   INFO - agnostic.FrequentEventDetector -
Too many events posted, #1. Event:
com.intellij.openapi.application.TransactionGuardImpl$6@14f685ab 
> > 2017-05-08 13:37:39,040 [ 791487]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> > 2017-05-08 13:37:39,114 [ 791561]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> > 2017-05-08 13:37:39,141 [ 791588]   INFO - pl.ProjectRootManagerComponent -
project roots have changed 
> > 2017-05-08 13:37:39,154 [ 791601]   INFO - e.project.sync.GradleSyncState -
Sync with Gradle successful for project 'clankium'. 
> > 
> > Note that it takes 13 minutes to sync.
> 
> Later the sync is shown as failed with lots of messages like: "You have called
ADD_LIBRARY for library ipc_param_traits without any source files. This
typically indicates a problem with your CMakeLists.txt file"

Other mistakes are:

a few of these: "Target "third_party__mesa_osmesa" of type MODULE_LIBRARY may
not be linked
  into another target.  One may link only to STATIC or SHARED libraries, or
  to executables with the ENABLE_EXPORTS property set."

And plenty (~1.5k) of these:

CMake Error: The following variables are used in this project, but they are set
to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake
files:
library__android_support__for_android_webview__test__android_webview_unittests__library
    linked by target "android_webview__test__android_webview_unittests__library"
in directory /usr/local/google/code/clankium/src/out/Release
library__android_support__for_android_webview__test_libdrawgl
    linked by target "android_webview__test_libdrawgl" in directory
/usr/local/google/code/clankium/src/out/Release
...
library__android_support__for_android_webview__test_libstandalonelibwebviewchromium
    linked by target "android_webview__test_libstandalonelibwebviewchromium" in
directory /usr/local/google/code/clankium/src/out/Release

These errors don't seem to be caused by my change though.

[whywhat, 2017-05-08 18:40:38]

The CQ bit was checked by avayvod@chromium.org

[Peter Wen, 2017-05-08 18:40:42]

Unfortunately I had many similar errors as well. Still quite a bit of work
necessary to improve that script and make it work for gn/AS.

[commit-bot: I haz the power, 2017-05-08 18:41:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 23:29:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 23:29:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[whywhat, 2017-05-09 12:55:24]

The CQ bit was checked by avayvod@chromium.org

[commit-bot: I haz the power, 2017-05-09 12:55:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 13:02:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494334524007060, "parent_rev":
"69dd7a2cb52b0bcf60b783081f5280d88990d401", "commit_rev":
"23bc56150efb4ae54f6662e8552ac693fb41d485"}

[commit-bot: I haz the power, 2017-05-09 13:03:01]

Description was changed from

==========
[Android, Tools] Speed up gn_to_cmake.py with caching

BUG=694699
TEST=local run
==========

to

==========
[Android, Tools] Speed up gn_to_cmake.py with caching

BUG=694699
TEST=local run

Review-Url: https://codereview.chromium.org/2866863003
Cr-Commit-Position: refs/heads/master@{#470299}
Committed:
https://chromium.googlesource.com/chromium/src/+/23bc56150efb4ae54f6662e8552a...
==========

[commit-bot: I haz the power, 2017-05-09 13:03:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23bc56150efb4ae54f6662e8552a...