bluetooth: web: Remove now-duplicate max name length tests.

bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

The names are simplified to:
  "max-length-name*.html"

BUG=653718
Review-Url: https://codereview.chromium.org/2866783002
Cr-Commit-Position: refs/heads/master@{#471540}
Committed: https://chromium.googlesource.com/chromium/src/+/dd54acf6aaaeac88dd7aa1487c1cca25c9b6ffcf

[scheib, 2017-05-05 19:52:24]

Description was changed from

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 tests we keep "*max-length-for-device-name*"
have these duplicates removed:

max-length-for-name-in-adv-name.html
max-length-for-name-in-adv-namePrefix.html
unicode-max-length-for-name-in-adv-namePrefix.html
unicode-max-length-for-name-in-adv-name.html
unicode-max-length-for-name-in-adv-namePrefix.html

These duplicate tests should have been removed in that
change: https://codereview.chromium.org/2642123003

BUG=653718
==========

to

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

We keep 4 tests: "*max-length-for-device-name*"
and remove "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

BUG=653718
==========

[scheib, 2017-05-05 19:54:25]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[scheib, 2017-05-05 19:54:25]

Code search to see the tests to keep and remove:
https://cs.chromium.org/search/?sq=package:chromium&type=cs&q=f:max-length-fo...

[scheib, 2017-05-05 19:54:52]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 19:55:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 21:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:30:33]

Dry run: This issue passed the CQ dry run.

[ortuno, 2017-05-08 01:13:48]

lgtm

Should we simplify the naming as well? 

max-length-for-device-name-name.html       -> max-length-name.html
max-length-for-device-name-namePrefix.html -> max-length-namePrefix.html

[scheib, 2017-05-08 19:52:56]

Description was changed from

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

We keep 4 tests: "*max-length-for-device-name*"
and remove "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

BUG=653718
==========

to

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

BUG=653718
==========

[scheib, 2017-05-08 19:54:11]

On 2017/05/08 01:13:48, ortuno wrote:
> lgtm
> 
> Should we simplify the naming as well? 
> 
> max-length-for-device-name-name.html       -> max-length-name.html
> max-length-for-device-name-namePrefix.html -> max-length-namePrefix.html

Oh bother, now you made me look and I feel a few others need renaming, plus
we're missing the obvious "max-length succeeds" variants and only have
"max-length+1 fails". 

I'll wait for you to land https://codereview.chromium.org/2858183002/ to avoid
conflicts.

[scheib, 2017-05-13 00:31:27]

Description was changed from

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

BUG=653718
==========

to

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

The names are simplified to:
  "max-length-name*.html"

BUG=653718
==========

[scheib, 2017-05-13 00:32:11]

The CQ bit was checked by scheib@chromium.org

[scheib, 2017-05-13 00:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2866783002/#ps40001
(title: "Merge TOT")

[commit-bot: I haz the power, 2017-05-13 00:33:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2017-05-13 00:41:30]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2017-05-13 00:44:16]

Patchset #3 (id:40001) has been deleted

[scheib, 2017-05-13 00:44:28]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[scheib, 2017-05-13 00:44:48]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2017-05-13 00:44:49]

The CQ bit was checked by scheib@chromium.org

[scheib, 2017-05-13 00:44:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2866783002/#ps60001
(title: "Merge TOT")

[scheib, 2017-05-13 00:44:54]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:44:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 01:59:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494636294080280,
"parent_rev": "16d5c759172948ac4c1eeca0d5bcdbc7fb7535c6", "commit_rev":
"dd54acf6aaaeac88dd7aa1487c1cca25c9b6ffcf"}

[commit-bot: I haz the power, 2017-05-13 01:59:28]

Description was changed from

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

The names are simplified to:
  "max-length-name*.html"

BUG=653718
==========

to

==========
bluetooth: web: Remove now-duplicate max name length tests.

Code used to be stricter about filters and device names and
return different error types. We realized that the longest
name should always be viable to filter on. Only TypeErrors
are produced now, making these tests redundant.

4 test are kept, originally named:
  "*max-length-for-device-name*"
and remove 4
  "*max-length-for-name-in-adv-name*"

These duplicate tests should have been removed in
https://codereview.chromium.org/2642123003

The names are simplified to:
  "max-length-name*.html"

BUG=653718

Review-Url: https://codereview.chromium.org/2866783002
Cr-Commit-Position: refs/heads/master@{#471540}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd54acf6aaaeac88dd7aa1487c1c...
==========

[commit-bot: I haz the power, 2017-05-13 01:59:30]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/dd54acf6aaaeac88dd7aa1487c1c...