Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2866733002: Remove owning_id from EffectNode and replace it by an opaque stable_id (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 6 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove owning_id from EffectNode and replace it by an opaque stable_id In a subsequent patch, stable_id will be set to ElementId, not the owning id of the layer. BUG=718564 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : Merge branch 'master' into stable_id #

Patch Set 6 : none #

Patch Set 7 : none #

Patch Set 8 : none #

Patch Set 9 : none #

Patch Set 10 : none #

Patch Set 11 : none #

Patch Set 12 : none #

Patch Set 13 : none #

Patch Set 14 : none #

Patch Set 15 : none #

Patch Set 16 : none #

Patch Set 17 : none #

Patch Set 18 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -227 lines) Patch
M cc/blink/web_scrollbar_layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_scrollbar_layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +6 lines, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +6 lines, -1 line 0 comments Download
M cc/input/scrollbar_animation_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 24 chunks +55 lines, -47 lines 0 comments Download
M cc/layers/effect_tree_layer_list_iterator_unittest.cc View 1 2 3 chunks +17 lines, -17 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +0 lines, -10 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/scrollbar_layer_impl_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -10 lines 0 comments Download
M cc/test/layer_test_common.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_test_common.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +11 lines, -12 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +4 lines, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/effect_node.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -3 lines 0 comments Download
M cc/trees/effect_node.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 17 chunks +115 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 22 chunks +39 lines, -31 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/property_tree.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 6 chunks +20 lines, -1 line 0 comments Download
M cc/trees/property_tree.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +12 lines, -6 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorElementId.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebScrollbarLayer.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
chrishtr
Description was changed from ========== none none BUG= ========== to ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ...
3 years, 7 months ago (2017-05-05 16:44:39 UTC) #1
chrishtr
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== none none BUG= ...
3 years, 7 months ago (2017-05-05 16:44:39 UTC) #2
chrishtr
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== owner_id -> stable_id ...
3 years, 7 months ago (2017-05-05 16:45:24 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 00:37:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866733002/40001
3 years, 7 months ago (2017-05-06 00:38:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 01:07:52 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/263548)
3 years, 7 months ago (2017-05-06 01:07:53 UTC) #7
chrishtr
Description was changed from ========== owner_id -> stable_id BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Remove owning_id ...
3 years, 7 months ago (2017-05-06 17:06:12 UTC) #8
chrishtr
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 17:06:33 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866733002/60001
3 years, 7 months ago (2017-05-06 17:07:09 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 19:11:25 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/446965)
3 years, 7 months ago (2017-05-06 19:11:25 UTC) #12
chrishtr
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 18:33:55 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:35:09 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698