Move -fvisibility-inlines-hidden to the respective compiler config

Move -fvisibility-inlines-hidden to the respective compiler config

gcc's -Wattributes will warn if you have a class that has visibility
default and one of its members is a template that consists entirely of
inlines and thus is hidden.

Moving it to a config allows for gn files to control this setting.

BUG=v8:6339
R=brettw@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2866703002
Cr-Commit-Position: refs/heads/master@{#470575}
Committed: https://chromium.googlesource.com/chromium/src/+/7475d0c2ee929ce0c2fe346fd7ebb6937f89d9e3

[jochen (gone - plz use gerrit), 2017-05-05 13:41:59]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:42:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 15:54:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:54:50]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-09 13:51:09]

Brett, could you please review this patch?

[brettw, 2017-05-09 19:00:32]

lgtm

[jochen (gone - plz use gerrit), 2017-05-10 07:28:08]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:29:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 07:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:33:43]

Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2017-05-10 08:15:16]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-05-10 08:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2866703002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-10 08:15:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:34:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2017-05-10 13:19:58]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-05-10 13:20:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:02:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494422398541850,
"parent_rev": "0323cf72bf86e9995b9bc1409aeda5b070ce8727", "commit_rev":
"7475d0c2ee929ce0c2fe346fd7ebb6937f89d9e3"}

[commit-bot: I haz the power, 2017-05-10 15:02:09]

Description was changed from

==========
Move -fvisibility-inlines-hidden to the respective compiler config

gcc's -Wattributes will warn if you have a class that has visibility
default and one of its members is a template that consists entirely of
inlines and thus is hidden.

Moving it to a config allows for gn files to control this setting.

BUG=v8:6339
R=brettw@chromium.org,machenbach@chromium.org
==========

to

==========
Move -fvisibility-inlines-hidden to the respective compiler config

gcc's -Wattributes will warn if you have a class that has visibility
default and one of its members is a template that consists entirely of
inlines and thus is hidden.

Moving it to a config allows for gn files to control this setting.

BUG=v8:6339
R=brettw@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2866703002
Cr-Commit-Position: refs/heads/master@{#470575}
Committed:
https://chromium.googlesource.com/chromium/src/+/7475d0c2ee929ce0c2fe346fd7eb...
==========

[commit-bot: I haz the power, 2017-05-10 15:02:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7475d0c2ee929ce0c2fe346fd7eb...