Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2866703002: Move -fvisibility-inlines-hidden to the respective compiler config (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/gcc/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 ":compiler_codegen", 182 ":compiler_codegen",
183 ] 183 ]
184 184
185 # In general, Windows is totally different, but all the other builds share 185 # In general, Windows is totally different, but all the other builds share
186 # some common GCC configuration. 186 # some common GCC configuration.
187 if (!is_win) { 187 if (!is_win) {
188 # Common GCC compiler flags setup. 188 # Common GCC compiler flags setup.
189 # -------------------------------- 189 # --------------------------------
190 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204 190 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204
191 191
192 # Visibility attribute is not supported on AIX.
193 if (current_os != "aix") {
194 cflags_cc += [
195 # Not exporting C++ inline functions can generally be applied anywhere
196 # so we do so here. Normal function visibility is controlled by
197 # //build/config/gcc:symbol_visibility_hidden.
198 "-fvisibility-inlines-hidden",
199 ]
200 }
201
202 # Stack protection. 192 # Stack protection.
203 if (is_mac) { 193 if (is_mac) {
204 # The strong variant of the stack protector significantly increases 194 # The strong variant of the stack protector significantly increases
205 # binary size, so only enable it in debug mode. 195 # binary size, so only enable it in debug mode.
206 if (is_debug) { 196 if (is_debug) {
207 cflags += [ "-fstack-protector-strong" ] 197 cflags += [ "-fstack-protector-strong" ]
208 } else { 198 } else {
209 cflags += [ "-fstack-protector" ] 199 cflags += [ "-fstack-protector" ]
210 } 200 }
211 } else if (is_posix && !is_chromeos && !is_nacl) { 201 } else if (is_posix && !is_chromeos && !is_nacl) {
(...skipping 1552 matching lines...) Expand 10 before | Expand all | Expand 10 after
1764 1754
1765 if (is_ios || is_mac) { 1755 if (is_ios || is_mac) {
1766 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1756 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1767 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1757 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1768 config("enable_arc") { 1758 config("enable_arc") {
1769 common_flags = [ "-fobjc-arc" ] 1759 common_flags = [ "-fobjc-arc" ]
1770 cflags_objc = common_flags 1760 cflags_objc = common_flags
1771 cflags_objcc = common_flags 1761 cflags_objcc = common_flags
1772 } 1762 }
1773 } 1763 }
OLDNEW
« no previous file with comments | « no previous file | build/config/gcc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698