[Reland] Use dropdown list for admin areas in pr form.

Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: Handler().PostDelayed receives the time-out, 
but may add an additional delay to that. 
Therefore, sometimes, even if the time-out is set to 0,  
the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911
Review-Url: https://codereview.chromium.org/2866643004
Cr-Commit-Position: refs/heads/master@{#470225}
Committed: https://chromium.googlesource.com/chromium/src/+/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090

[Parastoo, 2017-05-05 15:13:05]

Description was changed from

==========
Original CL 2812893002

BUG=
==========

to

==========
Original CL 2812893002

BUG=
==========

[Parastoo, 2017-05-05 15:17:49]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 15:18:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 15:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 15:26:42]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Parastoo, 2017-05-05 15:55:31]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[Parastoo, 2017-05-05 15:55:44]

Patchset #2 (id:20001) has been deleted

[Parastoo, 2017-05-05 15:55:52]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-05-05 15:56:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-05-05 15:59:18]

Patchset #1 (id:1) has been deleted

[Parastoo, 2017-05-05 15:59:41]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 16:00:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 16:07:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 16:07:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Parastoo, 2017-05-05 16:31:55]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[Parastoo, 2017-05-05 16:32:02]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-05-05 16:33:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 16:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 16:44:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Parastoo, 2017-05-05 16:58:15]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[Parastoo, 2017-05-05 16:58:30]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2017-05-05 16:58:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-05-05 17:38:13]

The CQ bit was checked by parastoog@google.com

[commit-bot: I haz the power, 2017-05-05 17:38:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:38:40]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Parastoo, 2017-05-05 17:44:17]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 17:44:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 18:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 18:37:16]

Dry run: This issue passed the CQ dry run.

[Parastoo, 2017-05-05 19:09:01]

Description was changed from

==========
Original CL 2812893002

BUG=
==========

to

==========
Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: PostDelayed receives the time-out, but may add an
additional delay to that. Therefore, sometimes, even if the time-out
is set to 0, the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911
==========

[Parastoo, 2017-05-05 19:10:43]

parastoog@google.com changed reviewers:
+ mathp@chromium.org, sebsg@chromium.org

[Parastoo, 2017-05-05 19:10:44]

sebsg@chromium.org: Please review changes in 

mathp@chromium.org: Please review changes in

[Parastoo, 2017-05-05 19:11:21]

parastoog@google.com changed reviewers:
+ dfalcantara@chromium.org

[Parastoo, 2017-05-05 19:11:22]

dfalcantara@chromium.org: Please review changes in

[Parastoo, 2017-05-05 19:17:10]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 19:17:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-05-05 19:18:29]

Description was changed from

==========
Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: PostDelayed receives the time-out, but may add an
additional delay to that. Therefore, sometimes, even if the time-out
is set to 0, the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911
==========

to

==========
Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: Handler().PostDelayed receives the time-out, 
but may add an additional delay to that. 
Therefore, sometimes, even if the time-out is set to 0,  
the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911
==========

[sebsg, 2017-05-05 19:32:37]

Makes sense! Small comment.

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:363:
cancelAdminAreasRequest();
In the tests, you will still be loading the rules after "cancelling" them. Could
you change the code so that the rules are only loaded if we do not get in this
if? 

Thanks!

[Parastoo, 2017-05-05 19:59:44]

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:363:
cancelAdminAreasRequest();
On 2017/05/05 19:32:37, sebsg wrote:
> In the tests, you will still be loading the rules after "cancelling" them.
Could
> you change the code so that the rules are only loaded if we do not get in this
> if? 
> 
> Thanks!


As discussed, to do that, we'll need an extra check which is redundant for the
real world, and would only be used for tests. Therefore, we'll leave it as is
for now.

[Mathieu, 2017-05-05 20:23:40]

lgtm

[sebsg, 2017-05-05 20:36:47]

lgtm

[sebsg, 2017-05-05 20:36:49]

lgtm

[commit-bot: I haz the power, 2017-05-05 22:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:24:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Parastoo, 2017-05-08 13:08:37]

The CQ bit was checked by parastoog@google.com

[commit-bot: I haz the power, 2017-05-08 13:08:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 13:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 13:17:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gone, 2017-05-08 17:46:00]

java stuff lgtm

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:533:
public static PersonalDataManager getInstance() {
Does using the lazyholder pattern get around this?

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:935:
public static long getRequestTimeoutMS() {
javadoc

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:115:
@Override
annotation below javadoc

[Parastoo, 2017-05-08 20:51:44]

The CQ bit was checked by parastoog@google.com

[Parastoo, 2017-05-08 20:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
sebsg@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2866643004/#ps160001
(title: "Nit")

[Parastoo, 2017-05-08 20:52:33]

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:533:
public static PersonalDataManager getInstance() {
On 2017/05/08 17:46:00, slow (dfalcantara) wrote:
> Does using the lazyholder pattern get around this?
> 
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

As we discussed, we'll leave it as is for now. No consensus on this issue in the
clank team yet.

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:935:
public static long getRequestTimeoutMS() {
On 2017/05/08 17:46:00, slow (dfalcantara) wrote:
> javadoc

Done.

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
(right):

https://codereview.chromium.org/2866643004/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java:115:
@Override
On 2017/05/08 17:46:00, slow (dfalcantara) wrote:
> annotation below javadoc

Done.

[commit-bot: I haz the power, 2017-05-08 20:52:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:48:30]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1494276704647280,
"parent_rev": "07950b667088314c5f4410ac7f77fbd46b43cb1e", "commit_rev":
"5e3734d5c1970621238dc4b5fa3d47a8fdd0b090"}

[commit-bot: I haz the power, 2017-05-09 04:48:46]

Description was changed from

==========
Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: Handler().PostDelayed receives the time-out, 
but may add an additional delay to that. 
Therefore, sometimes, even if the time-out is set to 0,  
the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911
==========

to

==========
Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk
failing on chromium.android/Marshmallow. The problem is fixed in this
CL.

Note:

To make the payment request tests independent of the network status,
the tests set the time-out = 0,
which means that the sub-keys must never be fetched,
and the address forms will always show a textfield, 
and not a dropdown for the admin areas. 

Problem with the previous CL:

The function: Handler().PostDelayed receives the time-out, 
but may add an additional delay to that. 
Therefore, sometimes, even if the time-out is set to 0,  
the sub-keys get fetched.

Solution:

To solve this problem, the case for time-out = 0 is checked at first,
and the call to the function PostDelayed is skipped if the condition
holds.


BUG=710911

Review-Url: https://codereview.chromium.org/2866643004
Cr-Commit-Position: refs/heads/master@{#470225}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e3734d5c1970621238dc4b5fa3d...
==========

[commit-bot: I haz the power, 2017-05-09 04:48:47]

Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5e3734d5c1970621238dc4b5fa3d...