Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2866473003: [heap] Reland "Use shared markbits in the concurrent marker." (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Use shared markbits in the concurrent marker." The concurrent marker now colors objects grey and black using the atomic markbit operations. The heap visitor is changed in two ways: 1) It iterates the map pointer of each object. 2) It guards object visitation with a predicate, which is overridden in the concurrent marker with the result of GreyToBlack transition. BUG=chromium:694255 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2866473003 Cr-Commit-Position: refs/heads/master@{#45144} Committed: https://chromium.googlesource.com/v8/v8/+/1b064d9cd015bfa8878e190243ca7cbdfe69482b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -32 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/concurrent-marking.cc View 4 chunks +32 lines, -20 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 8 chunks +44 lines, -10 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
ulan
Relanding without any changes from the original CL because the CL was revert due to ...
3 years, 7 months ago (2017-05-05 09:41:24 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-05 09:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866473003/20001
3 years, 7 months ago (2017-05-05 15:01:00 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:41:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1b064d9cd015bfa8878e190243ca7cbdfe6...

Powered by Google App Engine
This is Rietveld 408576698