Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2863933002: [heap] Reland "Prepare IncrementalMarking::VisitObject for concurrent marking." (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Prepare IncrementalMarking::VisitObject for concurrent marking." Currently the VisitObject function iterates the object and then colors it black. This does not work well with concurrent marking. The function should instead first try to mark the object black and iterate its body only if the color transition succeeds. BUG=chromium:694255 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2863933002 Cr-Commit-Position: refs/heads/master@{#45139} Committed: https://chromium.googlesource.com/v8/v8/+/02a7c020bd0ebc25dd1688795a730fb1ec1da4e3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/heap/incremental-marking.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 chunks +12 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
ulan
Relanding without any changes from the original CL because the CL was revert due to ...
3 years, 7 months ago (2017-05-05 09:38:55 UTC) #4
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-05 09:39:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863933002/20001
3 years, 7 months ago (2017-05-05 14:06:05 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 14:56:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/02a7c020bd0ebc25dd1688795a730fb1ec1...

Powered by Google App Engine
This is Rietveld 408576698