Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2866473002: Revert "Switch from "winio" to "npipe"." (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 7 months ago
Reviewers:
Vadim Sh., iannucci, nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Revert "Switch from "winio" to "npipe"." This reverts commit 6cb138dd7f4d900c66b22f22b9bbde1b0c4ff975. The "winio" project has reportedly fixed the underlying bug, so let's try this again. BUG=chromium:699182 TEST=None Review-Url: https://codereview.chromium.org/2866473002 Committed: https://github.com/luci/luci-go/commit/5251ea3062e8c1be9e483d1e3d7a0cd4640cf4fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M logdog/client/butler/streamserver/namedPipe_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download
M logdog/client/butler/streamserver/namedPipe_windows_test.go View 1 chunk +1 line, -3 lines 0 comments Download
M logdog/client/butlerlib/streamclient/client_namedPipe_windows.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dnj
PTAL! Will roll "winio" in luci-go when I land/roll this.
3 years, 7 months ago (2017-05-04 17:47:45 UTC) #4
Vadim Sh.
lgtm re rolling, see https://chromium-review.googlesource.com/c/495946/ and Dave's comment there about win-io requiring cgo :(
3 years, 7 months ago (2017-05-04 17:49:28 UTC) #5
Vadim Sh.
On 2017/05/04 17:49:28, Vadim Sh. wrote: > lgtm > > re rolling, see https://chromium-review.googlesource.com/c/495946/ and ...
3 years, 7 months ago (2017-05-04 17:51:21 UTC) #6
dnj
Closing for now, since new "winio" requires cgo and we don't want to have to ...
3 years, 7 months ago (2017-05-04 18:21:26 UTC) #10
dnj
re-opening and landing now that cgo-free winio has landed.
3 years, 7 months ago (2017-05-09 17:35:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866473002/1
3 years, 7 months ago (2017-05-09 17:35:49 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:42:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/5251ea3062e8c1be9e483d1e3d7a0cd4640cf4fe

Powered by Google App Engine
This is Rietveld 408576698