logdog/client/butler/streamserver/namedPipe_windows_test.go - Issue 2866473002: Revert "Switch from "winio" to "npipe"."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/client/butler/streamserver/namedPipe_windows_test.go

Issue 2866473002: Revert "Switch from "winio" to "npipe"." (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/client/butler/streamserver/namedPipe_windows_test.go

diff --git a/logdog/client/butler/streamserver/namedPipe_windows_test.go b/logdog/client/butler/streamserver/namedPipe_windows_test.go

index 63edd13c6935e19197367ab5a5a0145760963947..f056ffba1504b6f230334f0384f0bce70ef2ceea 100644

--- a/logdog/client/butler/streamserver/namedPipe_windows_test.go

+++ b/logdog/client/butler/streamserver/namedPipe_windows_test.go

@@ -23,9 +23,7 @@ func TestWindowsNamedPipeServer(t *testing.T) {

pid := os.Getpid()

- // TODO(dnj): Re-enable after switching back to "winio" pending bug.

- // See: crbug.com/702105

- SkipConvey(`A named pipe server`, t, func() {

+ Convey(`A named pipe server`, t, func() {

ctx := context.Background()

Convey(`Will refuse to create if there is an empty path.`, func() {