Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility

Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (patchset #2 id:20001 of https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.


Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
> 
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
> 
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed: https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01cad436c3da26c

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442
Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}
Committed: https://chromium.googlesource.com/chromium/src/+/c84e3575dfa679edeeb4efe7c906d86425117e5f

[stevenjb, 2017-05-04 17:40:02]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-04 17:40:02]

Created Revert of MD Settings: Elim SettingsSubpageBrowsertest and
SettingsPageVisibility

[commit-bot: I haz the power, 2017-05-04 17:40:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-04 17:44:01]

lgtm

[commit-bot: I haz the power, 2017-05-04 18:40:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493919602328680, "parent_rev":
"aee22dff8af196f1b8252f69d4cefc7c18893cf0", "commit_rev":
"c84e3575dfa679edeeb4efe7c906d86425117e5f"}

[commit-bot: I haz the power, 2017-05-04 18:40:55]

Description was changed from

==========
Revert of MD Settings: Elim SettingsSubpageBrowsertest and
SettingsPageVisibility (patchset #2 id:20001 of
https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter
intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.


Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
> 
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
> 
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01c...

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442
==========

to

==========
Revert of MD Settings: Elim SettingsSubpageBrowsertest and
SettingsPageVisibility (patchset #2 id:20001 of
https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter
intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.


Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
> 
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
> 
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> 
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01c...

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442

Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}
Committed:
https://chromium.googlesource.com/chromium/src/+/c84e3575dfa679edeeb4efe7c906...
==========

[commit-bot: I haz the power, 2017-05-04 18:40:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c84e3575dfa679edeeb4efe7c906...

[michaelpg, 2017-05-04 18:41:17]

lgtm