Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility

chrome/browser/resources/settings/settings_ui/settings_ui.js

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index dbfdea08d43eeeb94fe5124b2b62dcd21c2833ce..20dde6a077414a3161372341a05ed00962af8cac 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -48,16 +48,15 @@
     },
 
     /**
-     * Dictionary defining page visibility. Pages are hidden when their entry
-     * is set to *false*. i.e. visibility defaults to true.
-     * @private {!PageVisibility}
+     * Dictionary defining page visibility.
+     * This is only set when in guest mode. All pages are visible when not set
+     * because polymer only notifies after a property is set.
+     * @private {!GuestModePageVisibility}
      */
-    pageVisibility_: {
-      type: Object,
-      value: function() {
-        return {};
-      },
-    },
+    pageVisibility_: Object,
+
+    /** @private */
+    showAndroidApps_: Boolean,
 
     /** @private */
     lastSearchQuery_: {
@@ -157,11 +156,8 @@
       };
     }
 
-// <if expr="chromeos">
-    this.pageVisibility_.androidApps =
-        loadTimeData.valueExists('androidAppsAllowed') &&
+    this.showAndroidApps_ = loadTimeData.valueExists('androidAppsAllowed') &&
         loadTimeData.getBoolean('androidAppsAllowed');
-// </if>
   },
 
   /** @private {?IntersectionObserver} */