Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866223002:
Add htm and html to pingable download file types. (Closed)
|
Created:
3 years, 7 months ago by Jialiu Lin Modified:
3 years, 7 months ago Reviewers:
Nathan Parker CC:
arv+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd htm and html to pingable download file types.
BUG=719784
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2866223002
Cr-Commit-Position: refs/heads/master@{#470514}
Committed: https://chromium.googlesource.com/chromium/src/+/af37d9515d320cd311123984cafea8d18069c653
Patch Set 1 #
Total comments: 2
Patch Set 2 : add bug number and explanation #
Messages
Total messages: 29 (18 generated)
Description was changed from ========== Add htm and html to pingable download file types. BUG=719784 ========== to ========== Add htm and html to pingable download file types. BUG=719784 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jialiul@chromium.org changed reviewers: + nparker@chromium.org
LGTM % comments. Thanks! https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right): https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... chrome/browser/resources/safe_browsing/download_file_types.asciipb:1812: # HTML file. You could explain that these are used in UwS campaigns via a two-level download scheme. And how about adding a crbug link here, so we can easily lookup the rationale? Also, file a bug. :-)
LGTM % comments. Thanks! https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right): https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... chrome/browser/resources/safe_browsing/download_file_types.asciipb:1812: # HTML file. You could explain that these are used in UwS campaigns via a two-level download scheme. And how about adding a crbug link here, so we can easily lookup the rationale? Also, file a bug. :-)
oops, disregard my comment about filing a bug.
The CQ bit was checked by jialiul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks nparker@! https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right): https://codereview.chromium.org/2866223002/diff/1/chrome/browser/resources/sa... chrome/browser/resources/safe_browsing/download_file_types.asciipb:1812: # HTML file. On 2017/05/09 at 22:00:22, Nathan Parker wrote: > You could explain that these are used in UwS campaigns via a two-level download scheme. > > And how about adding a crbug link here, so we can easily lookup the rationale? Also, file a bug. :-) crbug.com/719784 filed for this CL. :-) Added more explanation.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jialiul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org Link to the patchset: https://codereview.chromium.org/2866223002/#ps20001 (title: "add bug number and explanation")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by jialiul@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by jialiul@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494401294809840,
"parent_rev": "c140ef12a0591bc5b770c97b1b23d6c83a49fb20", "commit_rev":
"af37d9515d320cd311123984cafea8d18069c653"}
Message was sent while issue was closed.
Description was changed from ========== Add htm and html to pingable download file types. BUG=719784 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add htm and html to pingable download file types. BUG=719784 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2866223002 Cr-Commit-Position: refs/heads/master@{#470514} Committed: https://chromium.googlesource.com/chromium/src/+/af37d9515d320cd311123984cafe... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/af37d9515d320cd311123984cafe... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
