Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: chrome/browser/resources/safe_browsing/README.md

Issue 2866223002: Add htm and html to pingable download file types. (Closed)
Patch Set: add bug number and explanation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/safe_browsing/download_file_types.asciipb » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/safe_browsing/README.md
diff --git a/chrome/browser/resources/safe_browsing/README.md b/chrome/browser/resources/safe_browsing/README.md
index c745b96717105ad0e1f6fd0e5caf61822d0f1998..15916e4016c6e20d994985659995b5c5d1266b27 100644
--- a/chrome/browser/resources/safe_browsing/README.md
+++ b/chrome/browser/resources/safe_browsing/README.md
@@ -10,7 +10,7 @@ Rendered version of this file: https://chromium.googlesource.com/chromium/src/+/
## Procedure for adding/modifying file type(s)
- * **Edit** `download_file_types.asciipb` and update `histograms.xml`
+ * **Edit** `download_file_types.asciipb` and update `enums.xml`
* Get it reviewed, **submit.**
* **Push** it to all users via component update:
* Wait 1-3 day for this to run on Canary to verify it doesn't crash Chrome.
@@ -34,7 +34,7 @@ See `download_file_types.proto` for all fields.
first one wins. Only the `default_file_type` should leave this unset.
* `uma_value`: (required) must be unique and match one in the
- `SBClientDownloadExtensions` enum in `histograms.xml`.
+ `SBClientDownloadExtensions` enum in `enums.xml`.
* `is_archive`: `True` if this filetype is a container for other files.
Leave it unset for `false`.
« no previous file with comments | « no previous file | chrome/browser/resources/safe_browsing/download_file_types.asciipb » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698