Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2866213002: Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849 (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849 This roll includes: - [inspector_protocol] added StringUtil::toDouble method as requirement [1] [1] https://codereview.chromium.org/2843223005/ BUG=712610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2846113002 Cr-Commit-Position: refs/heads/master@{#467878} (cherry picked from commit 3b3ae152b652a7a4240954a07172bd57bdd64a00) Review-Url: https://codereview.chromium.org/2866213002 . Cr-Commit-Position: refs/branch-heads/3071@{#474} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/96f98cf3f6b43d5c1c4b43ed50f72cb0c8a85507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M components/ui_devtools/string_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol_string.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/V8InspectorString.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Parser_cpp.template View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kozy
3 years, 7 months ago (2017-05-09 00:19:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96f98cf3f6b43d5c1c4b43ed50f72cb0c8a85507 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698