Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2846113002: Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849 (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/inspector_protocol to efefa86c3183d307f0a0e53bf568fe57c5b58849 This roll includes: - [inspector_protocol] added StringUtil::toDouble method as requirement [1] [1] https://codereview.chromium.org/2843223005/ BUG=712610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2846113002 Cr-Commit-Position: refs/heads/master@{#467878} Committed: https://chromium.googlesource.com/chromium/src/+/3b3ae152b652a7a4240954a07172bd57bdd64a00

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M components/ui_devtools/string_util.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol_string.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/V8InspectorString.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Parser_cpp.template View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Dmitry, please take a look. I'll land inspector_protocol to corresponded repository first and update this ...
3 years, 7 months ago (2017-04-27 21:43:44 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2846113002/diff/1/components/ui_devtools/string_util.h File components/ui_devtools/string_util.h (right): https://codereview.chromium.org/2846113002/diff/1/components/ui_devtools/string_util.h#newcode52 components/ui_devtools/string_util.h:52: v = 0.0; nit: return *ok ? v ...
3 years, 7 months ago (2017-04-27 23:06:31 UTC) #3
kozy
all done, thanks! https://codereview.chromium.org/2846113002/diff/1/components/ui_devtools/string_util.h File components/ui_devtools/string_util.h (right): https://codereview.chromium.org/2846113002/diff/1/components/ui_devtools/string_util.h#newcode52 components/ui_devtools/string_util.h:52: v = 0.0; On 2017/04/27 23:06:31, ...
3 years, 7 months ago (2017-04-28 00:16:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846113002/20001
3 years, 7 months ago (2017-04-28 02:05:19 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 03:47:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b3ae152b652a7a4240954a07172...

Powered by Google App Engine
This is Rietveld 408576698