Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2845273002: Form validation: Do not show validation bubble during printing. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
keishi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Form validation: Do not show validation bubble during printing. It was possible to show it in media query listener. BUG=714849 Review-Url: https://codereview.chromium.org/2845273002 Cr-Commit-Position: refs/heads/master@{#467941} Committed: https://chromium.googlesource.com/chromium/src/+/93c0e26115af080b07623c0588c6ba1cfa5a552a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp View 2 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
keishi@, would you review this please?
3 years, 7 months ago (2017-04-28 07:20:29 UTC) #4
keishi
LGTM
3 years, 7 months ago (2017-04-28 07:24:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845273002/1
3 years, 7 months ago (2017-04-28 09:12:18 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 09:18:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93c0e26115af080b07623c0588c6...

Powered by Google App Engine
This is Rietveld 408576698