[Isolates] Move contents of Top into Isolate....

[Isolates] Move contents of Top into Isolate.

- Interesting changes are in top.cc, isolate.cc, isolate.h.
- Other changes are textual replacement of Top:: with
  Isolate::Current()->.
- The code in top.cc belongs in isolate.cc, but we'll leave it where it is
  to make merging easier.


Committed: http://code.google.com/p/v8/source/detail?r=4907

[zarko, 2010-06-16 21:27:04]

http://codereview.chromium.org/2866008/diff/5002/26016
File src/contexts.h (right):

http://codereview.chromium.org/2866008/diff/5002/26016#newcode263
src/contexts.h:263: inline bool has_out_of_memory();
Moved the implementation of these to isolate.h to fix a vertical dependency
issue.

http://codereview.chromium.org/2866008/diff/5002/26035
File src/isolate.cc (right):

http://codereview.chromium.org/2866008/diff/5002/26035#newcode238
src/isolate.cc:238: void Isolate::TearDownAndRecreateGlobalIsolate() {
This gets called from internal::V8::TearDown() rather than simply destroying the
global isolate (just in case someone expects one of the previously-static
objects to still be around after V8 goes away).

[zarko, 2010-06-16 21:27:33]

Thanks
  Luke

[Maxim.Mossienko, 2010-06-16 21:54:46]

Drive by comment
Could somebody enlighten me, does inlining classes make small impact on 
our ability to merge 'experimental' branch with bleeding_edge?
Also inlining classes significantly increase size of the patch, perhaps we could
do it in second pass, after reaching Isolate goal (synced with bleeding_edge).
It makes reviewing simplier :)

[Vitaly Repeshko, 2010-06-21 16:39:43]

LGTM

http://codereview.chromium.org/2866008/diff/74078/64017
File src/builtins.cc (right):

http://codereview.chromium.org/2866008/diff/74078/64017#newcode152
src/builtins.cc:152:
Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
"c_entry_fp" is static.

http://codereview.chromium.org/2866008/diff/74078/64027
File src/frames.cc (right):

http://codereview.chromium.org/2866008/diff/74078/64027#newcode211
src/frames.cc:211: && Isolate::handler(Isolate::Current()->thread_local_top())
!= NULL),
nit: "&&" should be on the previous line.

http://codereview.chromium.org/2866008/diff/74078/64031
File src/handles.cc (right):

http://codereview.chromium.org/2866008/diff/74078/64031#newcode641
src/handles.cc:641: !Isolate::Current()->MayNamedAccess(*current,
HEAP->undefined_value(),
nit: Indent to line up with "c" on the previous line.

http://codereview.chromium.org/2866008/diff/74078/64041
File src/ic.cc (right):

http://codereview.chromium.org/2866008/diff/74078/64041#newcode85
src/ic.cc:85:
Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
"c_entry_fp" is static.

[Maxim.Mossienko, 2010-06-21 22:27:10]

There are some presubmit.py problems.

C:\Projects\v8.current\isolates\src\isolate.h:539:  Do not use variable-length
arrays.  Use an appropriately named ('k' followed by CamelCase) compile-time
constant for the size.  [runtime/arrays] [1]
Done processing isolate.h

top.cc:791:  At least two spaces is best between code and comments 
[whitespace/comments] [2]

top.h:0:  No copyright message found.  You should have a line: "Copyright [year]
<Copyright Owner>"  [legal/copyright] [5]


On 2010/06/21 16:39:43, Vitaly wrote:
> LGTM
> 
> http://codereview.chromium.org/2866008/diff/74078/64017
> File src/builtins.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64017#newcode152
> src/builtins.cc:152:
> Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
> "c_entry_fp" is static.
> 
> http://codereview.chromium.org/2866008/diff/74078/64027
> File src/frames.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64027#newcode211
> src/frames.cc:211: && Isolate::handler(Isolate::Current()->thread_local_top())
> != NULL),
> nit: "&&" should be on the previous line.
> 
> http://codereview.chromium.org/2866008/diff/74078/64031
> File src/handles.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64031#newcode641
> src/handles.cc:641: !Isolate::Current()->MayNamedAccess(*current,
> HEAP->undefined_value(),
> nit: Indent to line up with "c" on the previous line.
> 
> http://codereview.chromium.org/2866008/diff/74078/64041
> File src/ic.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64041#newcode85
> src/ic.cc:85:
> Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
> "c_entry_fp" is static.