Check in the libxslt roll script.

Check in the libxslt roll script.

This rolls libxslt to the same upstream point,
ac341cbd792ee572941cc9a66e73800219a1a386, but with some important
differences:

- The script which does the roll is included along with the roll
  itself.

- The source is consumed similarly to libxml, and similarly to how
  other projects integrate libxslt, by first producing a distribution
  which is then unpacked into the Chromium tree under libxslt/src.

- A patches is applied to the source and it is easy to add more
  patches; the patches will live in the source tree.

This also updates README.chromium to omit mentioning two patches we
already rolled in from upstream: crbug.com/676623 which was fixed
upstream in
https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75e8154addae5
and crbug.com/583171 which was fixed upstream after
https://git.gnome.org/browse/libxslt/commit/?id=91d0540ac9beaa86719a05b749219a69baa0dd8d
per crbug.com/583171#c22

BUG=708393
Review-Url: https://codereview.chromium.org/2865973002
Cr-Commit-Position: refs/heads/master@{#470285}
Committed: https://chromium.googlesource.com/chromium/src/+/6f776b2a04faede092dfb454616b1b6be2ee45c4

[dominicc (has gone to gerrit), 2017-05-08 08:05:33]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 08:05:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2017-05-08 08:07:22]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 08:07:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 10:36:22]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2017-05-09 00:56:42]

dominicc@chromium.org changed reviewers:
+ yosin@chromium.org

[dominicc (has gone to gerrit), 2017-05-09 00:56:44]

PTAL

The main part to review is third_party/libxslt/chromium/roll.py

Most of the diff is just moves from third_party/libxslt to
third_party/libxslt/src. Having the libxslt distribution in src makes rolling
easier because we can replace the src directory; when they are mixed together
this way it's tedious to preserve BUILD.gn, OWNERS, etc. while avoiding cruft
from old versions of libxslt.

This also keeps less scree from configure. The important ones--mac/config.h,
win32/config.h, linux/config.h don't show up in the diff because they have not
changed but they're still there.

[yosin_UTC9, 2017-05-09 01:19:07]

yosin@chromium.org changed reviewers:
+ hayatoito@gmail.com

[yosin_UTC9, 2017-05-09 01:19:10]

+hayato@ for python script review.

https://codereview.chromium.org/2865973002/diff/1/third_party/libxslt/chromiu...
File third_party/libxslt/chromium/get-file-attributes-a.patch (right):

https://codereview.chromium.org/2865973002/diff/1/third_party/libxslt/chromiu...
third_party/libxslt/chromium/get-file-attributes-a.patch:10: +    dwAttrs =
GetFileAttributesA(path);
(^_^)

[dominicc (has gone to gerrit), 2017-05-09 01:47:42]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:49:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 04:16:39]

Dry run: This issue passed the CQ dry run.

[hayato, 2017-05-09 06:31:43]

hayato@chromium.org changed reviewers:
+ hayato@chromium.org

[hayato, 2017-05-09 06:31:45]

https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
File third_party/libxslt/chromium/roll.py (right):

https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
third_party/libxslt/chromium/roll.py:1: #!/usr/bin/env python
Is this a new file written from scratch?
If we have the original python script from where this file was diverged, it
would be nice to see it so that a reviewer can review only the difference.

[dominicc (has gone to gerrit), 2017-05-09 06:35:05]

On 2017/05/09 at 06:31:45, hayato wrote:
>
https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
> File third_party/libxslt/chromium/roll.py (right):
> 
>
https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
> third_party/libxslt/chromium/roll.py:1: #!/usr/bin/env python
> Is this a new file written from scratch?
> If we have the original python script from where this file was diverged, it
would be nice to see it so that a reviewer can review only the difference.

This is basically new from scratch, it is derived from
https://github.com/dominiccooney/blink-tools/blob/master/roll.py which was never
checked in. third_party/libxml/chromium/roll.py is also derived from that, so
they have some things in common, but I would like them to live with their
dependencies; don't want to do modpath hacks; and do not expect them to last
long enough to make merging them worthwhile.

[hayato, 2017-05-09 06:52:47]

For roll.py, LGTM

It looks the script has been used for a while, and the script follows Python
Style Guide. I think no decent review is required to check that in to the
repository.

https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
File third_party/libxslt/chromium/roll.py (right):

https://codereview.chromium.org/2865973002/diff/10001/third_party/libxslt/chr...
third_party/libxslt/chromium/roll.py:156: """"Changes the working directory and
resets it on exit."""
Nit: """, instead of """".

[dominicc (has gone to gerrit), 2017-05-09 08:24:11]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2017-05-09 08:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/2865973002/#ps20001
(title: "Consistent quotes.")

[commit-bot: I haz the power, 2017-05-09 08:24:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 11:38:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494318251788260,
"parent_rev": "33f2124d4b3245ca20d3ceb683b15858ffa524c4", "commit_rev":
"6f776b2a04faede092dfb454616b1b6be2ee45c4"}

[commit-bot: I haz the power, 2017-05-09 11:39:12]

Description was changed from

==========
Check in the libxslt roll script.

This rolls libxslt to the same upstream point,
ac341cbd792ee572941cc9a66e73800219a1a386, but with some important
differences:

- The script which does the roll is included along with the roll
  itself.

- The source is consumed similarly to libxml, and similarly to how
  other projects integrate libxslt, by first producing a distribution
  which is then unpacked into the Chromium tree under libxslt/src.

- A patches is applied to the source and it is easy to add more
  patches; the patches will live in the source tree.

This also updates README.chromium to omit mentioning two patches we
already rolled in from upstream: crbug.com/676623 which was fixed
upstream in
https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75...
and crbug.com/583171 which was fixed upstream after
https://git.gnome.org/browse/libxslt/commit/?id=91d0540ac9beaa86719a05b749219...
per crbug.com/583171#c22

BUG=708393
==========

to

==========
Check in the libxslt roll script.

This rolls libxslt to the same upstream point,
ac341cbd792ee572941cc9a66e73800219a1a386, but with some important
differences:

- The script which does the roll is included along with the roll
  itself.

- The source is consumed similarly to libxml, and similarly to how
  other projects integrate libxslt, by first producing a distribution
  which is then unpacked into the Chromium tree under libxslt/src.

- A patches is applied to the source and it is easy to add more
  patches; the patches will live in the source tree.

This also updates README.chromium to omit mentioning two patches we
already rolled in from upstream: crbug.com/676623 which was fixed
upstream in
https://git.gnome.org/browse/libxslt/commit/?id=08ab2774b870de1c7b5a48693df75...
and crbug.com/583171 which was fixed upstream after
https://git.gnome.org/browse/libxslt/commit/?id=91d0540ac9beaa86719a05b749219...
per crbug.com/583171#c22

BUG=708393

Review-Url: https://codereview.chromium.org/2865973002
Cr-Commit-Position: refs/heads/master@{#470285}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f776b2a04faede092dfb454616b...
==========

[commit-bot: I haz the power, 2017-05-09 11:39:14]

Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f776b2a04faede092dfb454616b...