Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2865923005: Remove text_selection.* benchmarks (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
Reviewers:
mfomitchev
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove text_selection.* benchmarks These benchmarks have been failing everywhere. They also don't fit into any supported harnesses, so we just remove them. BUG=717215 Review-Url: https://codereview.chromium.org/2865923005 Cr-Commit-Position: refs/heads/master@{#470525} Committed: https://chromium.googlesource.com/chromium/src/+/bf020bf21b6829abe5443dd46ffee60c7d32ec09

Patch Set 1 #

Patch Set 2 : Remove left over references #

Patch Set 3 : Also remove the page sets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -235 lines) Patch
M tools/perf/benchmark.csv View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
D tools/perf/benchmarks/text_selection.py View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/perf/page_sets/text_selection_sites.py View 1 2 1 chunk +0 lines, -163 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
nednguyen
3 years, 7 months ago (2017-05-09 15:11:40 UTC) #3
mfomitchev
LGTM
3 years, 7 months ago (2017-05-09 17:38:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865923005/20001
3 years, 7 months ago (2017-05-09 17:46:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865923005/40001
3 years, 7 months ago (2017-05-09 18:38:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/174000)
3 years, 7 months ago (2017-05-09 19:09:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865923005/40001
3 years, 7 months ago (2017-05-09 19:11:26 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:39:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865923005/40001
3 years, 7 months ago (2017-05-10 09:57:07 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 11:16:07 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bf020bf21b6829abe5443dd46ffe...

Powered by Google App Engine
This is Rietveld 408576698