Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 2865923005: Remove text_selection.* benchmarks (Closed)
Patch Set: Also remove the page sets Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/text_selection.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run the first page of one benchmark for every module. 5 """Run the first page of one benchmark for every module.
6 6
7 Only benchmarks that have a composable measurement are included. 7 Only benchmarks that have a composable measurement are included.
8 Ideally this test would be comprehensive, however, running one page 8 Ideally this test would be comprehensive, however, running one page
9 of every benchmark would run impractically long. 9 of every benchmark would run impractically long.
10 """ 10 """
(...skipping 11 matching lines...) Expand all
22 22
23 from benchmarks import battor 23 from benchmarks import battor
24 from benchmarks import image_decoding 24 from benchmarks import image_decoding
25 from benchmarks import indexeddb_perf 25 from benchmarks import indexeddb_perf
26 from benchmarks import jetstream 26 from benchmarks import jetstream
27 from benchmarks import kraken 27 from benchmarks import kraken
28 from benchmarks import octane 28 from benchmarks import octane
29 from benchmarks import rasterize_and_record_micro 29 from benchmarks import rasterize_and_record_micro
30 from benchmarks import repaint 30 from benchmarks import repaint
31 from benchmarks import speedometer 31 from benchmarks import speedometer
32 from benchmarks import text_selection
33 from benchmarks import v8_browsing 32 from benchmarks import v8_browsing
34 33
35 34
36 def SmokeTestGenerator(benchmark, num_pages=1): 35 def SmokeTestGenerator(benchmark, num_pages=1):
37 """Generates a benchmark that includes first N pages from pageset. 36 """Generates a benchmark that includes first N pages from pageset.
38 37
39 Args: 38 Args:
40 benchmark: benchmark object to make smoke test. 39 benchmark: benchmark object to make smoke test.
41 num_pages: use the first N pages to run smoke test. 40 num_pages: use the first N pages to run smoke test.
42 """ 41 """
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 89
91 # The list of benchmark modules to be excluded from our smoke tests. 90 # The list of benchmark modules to be excluded from our smoke tests.
92 _BLACK_LIST_TEST_MODULES = { 91 _BLACK_LIST_TEST_MODULES = {
93 image_decoding, # Always fails on Mac10.9 Tests builder. 92 image_decoding, # Always fails on Mac10.9 Tests builder.
94 indexeddb_perf, # Always fails on Win7 & Android Tests builder. 93 indexeddb_perf, # Always fails on Win7 & Android Tests builder.
95 octane, # Often fails & take long time to timeout on cq bot. 94 octane, # Often fails & take long time to timeout on cq bot.
96 rasterize_and_record_micro, # Always fails on cq bot. 95 rasterize_and_record_micro, # Always fails on cq bot.
97 repaint, # Often fails & takes long time to timeout on cq bot. 96 repaint, # Often fails & takes long time to timeout on cq bot.
98 speedometer, # Takes 101 seconds. 97 speedometer, # Takes 101 seconds.
99 jetstream, # Take 206 seconds. 98 jetstream, # Take 206 seconds.
100 text_selection, # Always fails on cq bot.
101 kraken, # Flaky on Android, crbug.com/626174. 99 kraken, # Flaky on Android, crbug.com/626174.
102 v8_browsing, # Flaky on Android, crbug.com/628368. 100 v8_browsing, # Flaky on Android, crbug.com/628368.
103 battor #Flaky on android, crbug.com/618330. 101 battor #Flaky on android, crbug.com/618330.
104 } 102 }
105 103
106 104
107 def MergeDecorators(method, method_attribute, benchmark, benchmark_attribute): 105 def MergeDecorators(method, method_attribute, benchmark, benchmark_attribute):
108 # Do set union of attributes to eliminate duplicates. 106 # Do set union of attributes to eliminate duplicates.
109 merged_attributes = getattr(method, method_attribute, set()).union( 107 merged_attributes = getattr(method, method_attribute, set()).union(
110 getattr(benchmark, benchmark_attribute, set())) 108 getattr(benchmark, benchmark_attribute, set()))
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 MergeDecorators(method, disabled_method_attr, benchmark, 158 MergeDecorators(method, disabled_method_attr, benchmark,
161 disabled_benchmark_attr) 159 disabled_benchmark_attr)
162 MergeDecorators(method, enabled_method_attr, benchmark, 160 MergeDecorators(method, enabled_method_attr, benchmark,
163 enabled_benchmark_attr) 161 enabled_benchmark_attr)
164 162
165 setattr(BenchmarkSmokeTest, benchmark.Name(), method) 163 setattr(BenchmarkSmokeTest, benchmark.Name(), method)
166 164
167 suite.addTest(BenchmarkSmokeTest(benchmark.Name())) 165 suite.addTest(BenchmarkSmokeTest(benchmark.Name()))
168 166
169 return suite 167 return suite
OLDNEW
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/text_selection.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698