Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2865773002: Convert OfflineAudioContext to us new Audit (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert OfflineAudioContext to us new Audit Manually converted OfflienAudioContext to use new Audit. BUG=704967 TEST= OfflineAudioContext/offlineaudiocontext-promise-basic.html OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html Review-Url: https://codereview.chromium.org/2865773002 Cr-Commit-Position: refs/heads/master@{#470126} Committed: https://chromium.googlesource.com/chromium/src/+/8489f04d7f01db0ad19a1b129b361ff5091ba1d8

Patch Set 1 #

Patch Set 2 : clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -93 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html View 1 3 chunks +36 lines, -44 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html View 1 4 chunks +63 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 15:25:10 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-08 20:38:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865773002/20001
3 years, 7 months ago (2017-05-08 20:56:29 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:15:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8489f04d7f01db0ad19a1b129b36...

Powered by Google App Engine
This is Rietveld 408576698