third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html - Issue 2865773002: Convert OfflineAudioContext to us new Audit

Unified Diff: third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html

Issue 2865773002: Convert OfflineAudioContext to us new Audit (Closed)

Patch Set: clang-format Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html b/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html

index d647e0d829fd37061e194fe455116bfb2c9215ae..6f79e26c175cd1bc9fa9bbe729141fd3f1c7e36d 100644

--- a/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html

+++ b/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html

@@ -3,7 +3,7 @@

<head>

- <script src="../resources/audio-testing.js"></script>

+ <script src="../resources/audit.js"></script>

<title>OfflineAudioContext.startRendering Promise</title>

</head>

@@ -19,23 +19,27 @@

var audit = Audit.createTaskRunner();

- audit.defineTask('reject-promise', function (done) {

- // Create a context and verify that calling startRendering more than once causes a rejected

- // promise.

- var context = new OfflineAudioContext(contextChannels, renderFrames, sampleRate);

+ audit.define('reject-promise', (task, should) => {

+ // Create a context and verify that calling startRendering more than

+ // once causes a rejected promise.

+ var context =

+ new OfflineAudioContext(contextChannels, renderFrames, sampleRate);

context.startRendering();

- Should('Promise from calling startRendering twice',

- context.startRendering())

- .beRejected()

- .then(done);

+ should(

+ context.startRendering(),

+ 'Promise from calling startRendering twice')

+ .beRejected()

+ .then(() => task.done());

});

- audit.defineTask('promise-results', function (done) {

- // Create an offline context and verify that buffer returned by the promise matches the

- // expected results.

- context = new OfflineAudioContext(contextChannels, renderFrames, sampleRate);

+ audit.define('promise-results', (task, should) => {

+ // Create an offline context and verify that buffer returned by the

+ // promise matches the expected results.

+ context =

+ new OfflineAudioContext(contextChannels, renderFrames, sampleRate);

- var buffer = context.createBuffer(contextChannels, renderFrames, sampleRate);

+ var buffer =

+ context.createBuffer(contextChannels, renderFrames, sampleRate);

for (var k = 0; k < renderFrames; ++k) {

buffer.getChannelData(0)[k] = 1;

buffer.getChannelData(1)[k] = 2;

@@ -46,40 +50,28 @@

source.connect(context.destination);

source.start();

- context.startRendering().then(handlePromise).then(done);

+ context.startRendering()

+ .then(buffer => {

+ return handlePromise(should, buffer);

+ })

+ .then(() => task.done());

});

- audit.runTasks();

- function handlePromise(buffer)

- {

- renderedData = buffer;

- var success = true;

- Should("context.state", context.state)

- .beEqualTo("closed");

- Should("renderedData.numberOfChannels", renderedData.numberOfChannels)

- .beEqualTo(contextChannels);

- Should("renderedData.length", renderedData.length)

- .beEqualTo(renderFrames);

+ audit.run();

- for (var channel = 0; channel < contextChannels; ++channel) {

- var data = renderedData.getChannelData(channel);

- for (var k = 0; k < renderFrames; ++k) {

- if (data[k] != channel + 1) {

- success = false;

- badChannel = channel;

- badFrame = k;

- break;

- }

- if (!success)

- break;

- }

+ function handlePromise(should, renderedData) {

+ should(context.state, 'context.state').beEqualTo('closed');

+ should(renderedData.numberOfChannels, 'renderedData.numberOfChannels')

+ .beEqualTo(contextChannels);

+ should(renderedData.length, 'renderedData.length')

+ .beEqualTo(renderFrames);

- Should('OfflineAudioContext.startRendering promise rendered data',

- success)

- .summarize('correctly', 'incorrectly');

+ for (let channel = 0; channel < renderedData.numberOfChannels;

+ ++channel) {

+ should(

+ renderedData.getChannelData(channel), `Output channel ${channel}`)

+ .beConstantValueOf(channel + 1);

+ }

}

</script>