ash: Rename AppLaunchId to ShelfID.

ash: Rename AppLaunchId to ShelfID.

Simple rename to the more widely used alias.
Convert class to struct; move into shelf_types.*
Follow up to https://codereview.chromium.org/2860503002

BUG=557406
TEST=NONE
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2865743002
Cr-Commit-Position: refs/heads/master@{#469855}
Committed: https://chromium.googlesource.com/chromium/src/+/2eddc334c95ba670f38a4a656f25ad85a7a8f565

[msw, 2017-05-05 20:21:11]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 20:21:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-05-05 20:22:04]

Hey Scott, please take a look; thanks!

[sky, 2017-05-05 22:54:41]

LGTM

https://codereview.chromium.org/2865743002/diff/1/ash/public/cpp/shelf_types.h
File ash/public/cpp/shelf_types.h (right):

https://codereview.chromium.org/2865743002/diff/1/ash/public/cpp/shelf_types....
ash/public/cpp/shelf_types.h:141: ShelfID(const std::string& app_id, const
std::string& launch_id);
optional: use default value for launch_id and get rid of the other constructor,
or make both optional and get rid of the other two constructors.

[msw, 2017-05-05 23:17:48]

https://codereview.chromium.org/2865743002/diff/1/ash/public/cpp/shelf_types.h
File ash/public/cpp/shelf_types.h (right):

https://codereview.chromium.org/2865743002/diff/1/ash/public/cpp/shelf_types....
ash/public/cpp/shelf_types.h:141: ShelfID(const std::string& app_id, const
std::string& launch_id);
On 2017/05/05 22:54:40, sky wrote:
> optional: use default value for launch_id and get rid of the other
constructor,
> or make both optional and get rid of the other two constructors.

Good call, I made both optional and nixed the other ctors.
(I also thought about just using {} init, but perhaps that's odd)

[msw, 2017-05-05 23:17:51]

The CQ bit was checked by msw@chromium.org

[msw, 2017-05-05 23:17:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2865743002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-05-05 23:18:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 18:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494026271360070,
"parent_rev": "9ddcdeddcd8b04d0a0654d90b9a4cb9aa20faae1", "commit_rev":
"2eddc334c95ba670f38a4a656f25ad85a7a8f565"}

[commit-bot: I haz the power, 2017-05-06 18:57:04]

Description was changed from

==========
ash: Rename AppLaunchId to ShelfID.

Simple rename to the more widely used alias.
Convert class to struct; move into shelf_types.*
Follow up to https://codereview.chromium.org/2860503002

BUG=557406
TEST=NONE
R=sky@chromium.org
==========

to

==========
ash: Rename AppLaunchId to ShelfID.

Simple rename to the more widely used alias.
Convert class to struct; move into shelf_types.*
Follow up to https://codereview.chromium.org/2860503002

BUG=557406
TEST=NONE
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2865743002
Cr-Commit-Position: refs/heads/master@{#469855}
Committed:
https://chromium.googlesource.com/chromium/src/+/2eddc334c95ba670f38a4a656f25...
==========

[commit-bot: I haz the power, 2017-05-06 18:57:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2eddc334c95ba670f38a4a656f25...