ash: Rename AppLaunchId to ShelfID.

ash/public/cpp/shelf_types.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_PUBLIC_CPP_SHELF_TYPES_H_
 #define ASH_PUBLIC_CPP_SHELF_TYPES_H_
 
 #include <cstdint>
+#include <string>
 
-#include "ash/public/cpp/app_launch_id.h"
 #include "ash/public/cpp/ash_public_export.h"
 
 namespace ash {
 
 enum ShelfAlignment {
   SHELF_ALIGNMENT_BOTTOM,
   SHELF_ALIGNMENT_LEFT,
   SHELF_ALIGNMENT_RIGHT,
   // Top has never been supported.
 
@@ skipping 62 matching lines @@
   // An existing inactive window was activated.
   SHELF_ACTION_WINDOW_ACTIVATED,
 
   // The currently active window was minimized.
   SHELF_ACTION_WINDOW_MINIMIZED,
 
   // The app list launcher menu was shown.
   SHELF_ACTION_APP_LIST_SHOWN,
 };
 
-// TODO(msw): Rename AppLaunchId to ShelfID.
-using ShelfID = AppLaunchId;
-
 // The type of a shelf item.
 enum ShelfItemType {
   // Represents a running app panel.
   TYPE_APP_PANEL,
 
   // Represents a pinned shortcut to an app, the app may be running or not.
   TYPE_PINNED_APP,
 
   // Toggles visiblity of the app list.
   TYPE_APP_LIST,
@@ skipping 22 matching lines @@
   // A closed shelf item, i.e. has no live instance.
   STATUS_CLOSED,
   // A shelf item that has live instance.
   STATUS_RUNNING,
   // An active shelf item that has focus.
   STATUS_ACTIVE,
   // A shelf item that needs user's attention.
   STATUS_ATTENTION,
 };
 
+// A unique shelf item id composed of an |app_id| and a |launch_id|.
+// |app_id| is the non-empty application id associated with a set of windows.
+// |launch_id| is passed on app launch, to support multiple shelf items per app.
+// As an example, a remote desktop client may want each remote application to
+// have its own icon.
+struct ASH_PUBLIC_EXPORT ShelfID {
+  ShelfID(const std::string& app_id, const std::string& launch_id);

[sky, 2017/05/05 22:54:40]

optional: use default value for launch_id and get rid of the other constructor,
or make both optional and get rid of the other two constructors.

[msw, 2017/05/05 23:17:48]

Good call, I made both optional and nixed the other ctors.
(I also thought about just using {} init, but perhaps that's odd)

+  // Creates an ShelfID with an empty |launch_id|.
+  explicit ShelfID(const std::string& app_id);
+  // Empty constructor for pre-allocating.
+  ShelfID();
+  ~ShelfID();
+
+  ShelfID(const ShelfID& other);
+  ShelfID(ShelfID&& other);
+  ShelfID& operator=(const ShelfID& other);
+  bool operator==(const ShelfID& other) const;
+  bool operator!=(const ShelfID& other) const;
+  bool operator<(const ShelfID& other) const;
+
+  // Returns true if both the application id and launch id are empty.
+  // This is often used to determine if the id is invalid.
+  bool IsNull() const;
+
+  // The application id associated with a set of windows.
+  std::string app_id;
+  // An id passed on app launch, to support multiple shelf items per app.
+  std::string launch_id;
+};
+
 }  // namespace ash
 
 #endif  // ASH_PUBLIC_CPP_SHELF_TYPES_H_