Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2865713002: Remove ScopedComPtr::IsSameObject() (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, wfh+watch_chromium.org, je_julie, danakj+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedComPtr::IsSameObject() BUG=638327 Review-Url: https://codereview.chromium.org/2865713002 Cr-Commit-Position: refs/heads/master@{#470062} Committed: https://chromium.googlesource.com/chromium/src/+/c4a2186ea71c614e959404ea0e5125ad57d38288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -45 lines) Patch
M base/win/scoped_comptr.h View 1 chunk +0 lines, -17 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 3 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
robliao
dmazzoni@chromium.org: Please review changes in ui/views/accessibility/native_view_accessibility_win_unittest.cc scottmg@chromium.org: Please review this CL. Thanks all!
3 years, 7 months ago (2017-05-05 17:41:24 UTC) #4
scottmg
lgtm
3 years, 7 months ago (2017-05-05 17:47:21 UTC) #5
dmazzoni
lgtm
3 years, 7 months ago (2017-05-08 18:32:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865713002/1
3 years, 7 months ago (2017-05-08 18:34:06 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:46:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4a2186ea71c614e959404ea0e51...

Powered by Google App Engine
This is Rietveld 408576698