Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: base/win/scoped_comptr_unittest.cc

Issue 2865713002: Remove ScopedComPtr::IsSameObject() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/scoped_comptr.h" 5 #include "base/win/scoped_comptr.h"
6 6
7 #include <objbase.h> 7 #include <objbase.h>
8 #include <shlobj.h> 8 #include <shlobj.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 unk2.Attach(unk.Detach()); 44 unk2.Attach(unk.Detach());
45 EXPECT_TRUE(unk.Get() == NULL); 45 EXPECT_TRUE(unk.Get() == NULL);
46 EXPECT_TRUE(unk2.Get() != NULL); 46 EXPECT_TRUE(unk2.Get() != NULL);
47 47
48 ScopedComPtr<IMalloc> mem_alloc; 48 ScopedComPtr<IMalloc> mem_alloc;
49 EXPECT_TRUE(SUCCEEDED(CoGetMalloc(1, mem_alloc.Receive()))); 49 EXPECT_TRUE(SUCCEEDED(CoGetMalloc(1, mem_alloc.Receive())));
50 50
51 ScopedComPtr<IUnknown> qi_test; 51 ScopedComPtr<IUnknown> qi_test;
52 EXPECT_HRESULT_SUCCEEDED(mem_alloc.CopyTo(IID_PPV_ARGS(&qi_test))); 52 EXPECT_HRESULT_SUCCEEDED(mem_alloc.CopyTo(IID_PPV_ARGS(&qi_test)));
53 EXPECT_TRUE(qi_test.Get() != NULL); 53 EXPECT_TRUE(qi_test.Get() != NULL);
54 qi_test.Reset();
55
56 // test ScopedComPtr& constructor
57 ScopedComPtr<IMalloc> copy1(mem_alloc);
58 EXPECT_TRUE(copy1.IsSameObject(mem_alloc.Get()));
59 EXPECT_FALSE(copy1.IsSameObject(unk2.Get())); // unk2 is valid but different
60 EXPECT_FALSE(copy1.IsSameObject(unk.Get())); // unk is NULL
61
62 IMalloc* naked_copy = copy1.Detach();
63 copy1 = naked_copy; // Test the =(T*) operator.
64 naked_copy->Release();
65
66 copy1.Reset();
67 EXPECT_FALSE(copy1.IsSameObject(unk2.Get())); // unk2 is valid, copy1 is not
68
69 // test Interface* constructor
70 ScopedComPtr<IMalloc> copy2(static_cast<IMalloc*>(mem_alloc.Get()));
71 EXPECT_TRUE(copy2.IsSameObject(mem_alloc.Get()));
72
73 EXPECT_TRUE(SUCCEEDED(unk.QueryFrom(mem_alloc.Get())));
74 EXPECT_TRUE(unk.Get() != NULL);
75 unk.Reset();
76 EXPECT_TRUE(unk.Get() == NULL);
77 EXPECT_TRUE(unk.IsSameObject(copy1.Get())); // both are NULL
78 } 54 }
79 55
80 TEST(ScopedComPtrTest, ScopedComPtrVector) { 56 TEST(ScopedComPtrTest, ScopedComPtrVector) {
81 // Verify we don't get error C2558. 57 // Verify we don't get error C2558.
82 typedef ScopedComPtr<Dummy, &dummy_iid> Ptr; 58 typedef ScopedComPtr<Dummy, &dummy_iid> Ptr;
83 std::vector<Ptr> bleh; 59 std::vector<Ptr> bleh;
84 60
85 std::unique_ptr<Dummy> p(new Dummy); 61 std::unique_ptr<Dummy> p(new Dummy);
86 { 62 {
87 Ptr p2(p.get()); 63 Ptr p2(p.get());
(...skipping 14 matching lines...) Expand all
102 bleh.pop_back(); 78 bleh.pop_back();
103 EXPECT_EQ(p->adds, 4); 79 EXPECT_EQ(p->adds, 4);
104 EXPECT_EQ(p->releases, 2); 80 EXPECT_EQ(p->releases, 2);
105 } 81 }
106 EXPECT_EQ(p->adds, 4); 82 EXPECT_EQ(p->adds, 4);
107 EXPECT_EQ(p->releases, 4); 83 EXPECT_EQ(p->releases, 4);
108 } 84 }
109 85
110 } // namespace win 86 } // namespace win
111 } // namespace base 87 } // namespace base
OLDNEW
« no previous file with comments | « base/win/scoped_comptr.h ('k') | ui/views/accessibility/native_view_accessibility_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698