Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2865543002: MD Settings: Internet: Fix IP config visibility (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Fix IP config visibility In this CL: * Always show IP config section for remembered or connected networks. * Fix editing IP config when switching from automatic to static. BUG=717262 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856023002 Cr-Commit-Position: refs/heads/master@{#469215} (cherry picked from commit 1d11530a771298ce260f024b118864f66cdace4c) Review-Url: https://codereview.chromium.org/2865543002 . Cr-Commit-Position: refs/branch-heads/3071@{#409} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a8a34ad21983863dcfd0554e6b129257d936e1d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.js View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
stevenjb
3 years, 7 months ago (2017-05-04 21:50:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8a34ad21983863dcfd0554e6b129257d936e1d4.

Powered by Google App Engine
This is Rietveld 408576698