Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2856023002: MD Settings: Internet: Fix IP config visibility (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Fix IP config visibility In this CL: * Always show IP config section for remembered or connected networks. * Fix editing IP config when switching from automatic to static. BUG=717262 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856023002 Cr-Commit-Position: refs/heads/master@{#469215} Committed: https://chromium.googlesource.com/chromium/src/+/1d11530a771298ce260f024b118864f66cdace4c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.js View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
stevenjb
This fixes a bug in 59, so PTAL when you have a moment, thanks!
3 years, 7 months ago (2017-05-03 00:07:18 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/settings/internet_page/network_ip_config.js File chrome/browser/resources/settings/internet_page/network_ip_config.js (left): https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/settings/internet_page/network_ip_config.js#oldcode174 chrome/browser/resources/settings/internet_page/network_ip_config.js:174: if (!this.editable || this.automatic__) Closure compiler, you had ...
3 years, 7 months ago (2017-05-03 21:20:49 UTC) #4
stevenjb
https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/settings/internet_page/network_ip_config.js File chrome/browser/resources/settings/internet_page/network_ip_config.js (left): https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/settings/internet_page/network_ip_config.js#oldcode174 chrome/browser/resources/settings/internet_page/network_ip_config.js:174: if (!this.editable || this.automatic__) On 2017/05/03 21:20:48, michaelpg wrote: ...
3 years, 7 months ago (2017-05-03 21:26:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856023002/40001
3 years, 7 months ago (2017-05-03 23:10:52 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 00:24:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d11530a771298ce260f024b1188...

Powered by Google App Engine
This is Rietveld 408576698