MD Settings: Internet: Fix IP config visibility

MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}
Committed: https://chromium.googlesource.com/chromium/src/+/1d11530a771298ce260f024b118864f66cdace4c

[stevenjb, 2017-05-03 00:06:40]

Description was changed from

==========
MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
==========

to

==========
MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-03 00:07:18]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2017-05-03 00:07:18]

This fixes a bug in 59, so PTAL when you have a moment, thanks!

[michaelpg, 2017-05-03 21:20:49]

lgtm

https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_ip_config.js
(left):

https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_ip_config.js:174: if
(!this.editable || this.automatic__)
Closure compiler, you had one job....

[stevenjb, 2017-05-03 21:26:13]

https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_ip_config.js
(left):

https://codereview.chromium.org/2856023002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_ip_config.js:174: if
(!this.editable || this.automatic__)
On 2017/05/03 21:20:48, michaelpg wrote:
> Closure compiler, you had one job....

Rght?

[stevenjb, 2017-05-03 23:09:38]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-03 23:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2856023002/#ps20001
(title: "Rebase")

[stevenjb, 2017-05-03 23:09:44]

The CQ bit was unchecked by stevenjb@chromium.org

[stevenjb, 2017-05-03 23:10:21]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-05-03 23:10:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2856023002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-03 23:10:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 00:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493853021991140,
"parent_rev": "98255c447048dbbcd7e30dccff90b812f98adb5a", "commit_rev":
"1d11530a771298ce260f024b118864f66cdace4c"}

[commit-bot: I haz the power, 2017-05-04 00:24:24]

Description was changed from

==========
MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Fix IP config visibility

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d11530a771298ce260f024b1188...
==========

[commit-bot: I haz the power, 2017-05-04 00:24:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d11530a771298ce260f024b1188...