Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2865403002: Don't allow subsequence caching for fragmented PaintLayers. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow subsequence caching for fragmented PaintLayers. Fragmented PaintLayers do not paint atomically (though each fragment does). PaintController, however does not support a fragment as a DisplayItemClient key for subsequences. BUG=717335 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2865403002 Cr-Commit-Position: refs/heads/master@{#471087} Committed: https://chromium.googlesource.com/chromium/src/+/3d763bf3e6615ac7e407af1b9ffbe61f451186b3

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into multicolfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
chrishtr
3 years, 7 months ago (2017-05-09 21:50:15 UTC) #4
Xianzhu
lgtm
3 years, 7 months ago (2017-05-09 21:55:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865403002/1
3 years, 7 months ago (2017-05-09 21:58:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:06:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865403002/1
3 years, 7 months ago (2017-05-10 17:50:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450421)
3 years, 7 months ago (2017-05-10 19:59:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865403002/20001
3 years, 7 months ago (2017-05-11 14:57:03 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/175983)
3 years, 7 months ago (2017-05-11 15:46:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865403002/20001
3 years, 7 months ago (2017-05-11 20:30:45 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:18:40 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d763bf3e6615ac7e407af1b9ffb...

Powered by Google App Engine
This is Rietveld 408576698