Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2865403002: Don't allow subsequence caching for fragmented PaintLayers. (Closed)
Patch Set: Merge branch 'master' into multicolfix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 2751 matching lines...) Expand 10 before | Expand all | Expand 10 after
2762 GetCompositingState() != kPaintsIntoOwnBacking); 2762 GetCompositingState() != kPaintsIntoOwnBacking);
2763 } 2763 }
2764 2764
2765 return (Transform() || 2765 return (Transform() ||
2766 GetLayoutObject().Style()->GetPosition() == EPosition::kFixed) && 2766 GetLayoutObject().Style()->GetPosition() == EPosition::kFixed) &&
2767 ((global_paint_flags & kGlobalPaintFlattenCompositingLayers) || 2767 ((global_paint_flags & kGlobalPaintFlattenCompositingLayers) ||
2768 GetCompositingState() != kPaintsIntoOwnBacking); 2768 GetCompositingState() != kPaintsIntoOwnBacking);
2769 } 2769 }
2770 2770
2771 bool PaintLayer::SupportsSubsequenceCaching() const { 2771 bool PaintLayer::SupportsSubsequenceCaching() const {
2772 if (EnclosingPaginationLayer())
2773 return false;
2774
2772 // SVG paints atomically. 2775 // SVG paints atomically.
2773 if (GetLayoutObject().IsSVGRoot()) 2776 if (GetLayoutObject().IsSVGRoot())
2774 return true; 2777 return true;
2775 2778
2776 // Create subsequence for only stacking contexts whose painting are atomic. 2779 // Create subsequence for only stacking contexts whose painting are atomic.
2777 if (!StackingNode()->IsStackingContext()) 2780 if (!StackingNode()->IsStackingContext())
2778 return false; 2781 return false;
2779 2782
2780 // The layer doesn't have children. Subsequence caching is not worth it, 2783 // The layer doesn't have children. Subsequence caching is not worth it,
2781 // because normally the actual painting will be cheap. 2784 // because normally the actual painting will be cheap.
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
3324 } 3327 }
3325 3328
3326 void showLayerTree(const blink::LayoutObject* layoutObject) { 3329 void showLayerTree(const blink::LayoutObject* layoutObject) {
3327 if (!layoutObject) { 3330 if (!layoutObject) {
3328 LOG(INFO) << "Cannot showLayerTree. Root is (nil)"; 3331 LOG(INFO) << "Cannot showLayerTree. Root is (nil)";
3329 return; 3332 return;
3330 } 3333 }
3331 showLayerTree(layoutObject->EnclosingLayer()); 3334 showLayerTree(layoutObject->EnclosingLayer());
3332 } 3335 }
3333 #endif 3336 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698