Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2865383002: PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged (Closed)

Created:
3 years, 7 months ago by jdufault
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged Calling MaybeReleaseAdapter directly from BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since this can happen: BluetoothAdapterBlueZ::AdapterPropertyChanged -> BluetoothAdapterBlueZ::DiscoveringChanged -> BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter If BluetoothEventRouter is the only pointer holder left then the caller of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even before that function returns. BUG=710216 Review-Url: https://codereview.chromium.org/2852773002 Cr-Commit-Position: refs/heads/master@{#468180} (cherry picked from commit 518c599b12849fb5ca778427c877c2250d116455) Review-Url: https://codereview.chromium.org/2865383002 . Cr-Commit-Position: refs/branch-heads/3071@{#487} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/277d00927d269a72d50eed92c78bf1a9cc0e9b26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M extensions/browser/api/bluetooth/bluetooth_event_router.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
3 years, 7 months ago (2017-05-09 21:10:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
277d00927d269a72d50eed92c78bf1a9cc0e9b26.

Powered by Google App Engine
This is Rietveld 408576698